Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CSS property page: fill #35137

Merged
merged 16 commits into from
Aug 8, 2024
Merged

New CSS property page: fill #35137

merged 16 commits into from
Aug 8, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jul 26, 2024

related to #34763

@estelle estelle requested review from a team as code owners July 26, 2024 05:47
@estelle estelle requested review from chrisdavidmills and removed request for a team July 26, 2024 05:47
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/m [PR only] 51-500 LoC changed labels Jul 26, 2024
Copy link
Contributor

github-actions bot commented Jul 26, 2024

Preview URLs

Flaws (13)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/fill
Title: fill
Flaw count: 13

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/CSS/stroke
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/CSS/marker-end
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/CSS/marker-mid
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/CSS/marker-start
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/CSS/stroke
    • and 8 more flaws omitted

(comment last updated: 2024-08-08 06:57:01)

@bsmth
Copy link
Member

bsmth commented Aug 1, 2024

Thanks, Estelle. A couple of small suggestions and fixes to apply!

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle some bits for you to consider; nothing major though. Nice work!

files/en-us/web/css/fill/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/fill/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/fill/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/fill/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/fill/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/fill/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/fill/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/fill/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/fill/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/fill/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Aug 7, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Aug 7, 2024
@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Aug 7, 2024
@estelle
Copy link
Member Author

estelle commented Aug 7, 2024

i removed the redirects.txt file as it was creating a merge conflict. I'll double check that everything is working after this is live.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle perfect! This looks GTG to me.

@estelle
Copy link
Member Author

estelle commented Aug 8, 2024

Updated the redirects; all checks now passing.

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chrisdavidmills chrisdavidmills merged commit 2f79d93 into main Aug 8, 2024
9 checks passed
@chrisdavidmills chrisdavidmills deleted the fill branch August 8, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants