Native_manifests: pkcs11 paths may be relative #34873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URLs (comment last updated: 2024-08-08 17:51:25) |
rebloor
requested changes
Jul 22, 2024
files/en-us/mozilla/add-ons/webextensions/native_manifests/index.md
Outdated
Show resolved
Hide resolved
Undocumented support for relative paths existed for a long while, and became an explicit first-class supported feature in https://bugzilla.mozilla.org/show_bug.cgi?id=1759162 This fixes the documentation accordingly, to set the correct expectations. And prepend "PKCS 11" to "module" to emphasize that this fragment of the table is about the manifests for the pkcs11 API, to avoid confusion in case the reader was looking for the native messaging manifest.
Rob--W
force-pushed
the
pkcs11-path-relative
branch
from
e5af489
to
48f3462
Compare
|
@rebloor I've applied the requested change (removed comma) and rebased to the main branch just in case. |
rebloor
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clarifies that the "path" property in pkcs11 manifests can be relative, everywhere.
And prepend "PKCS 11" to "module" to emphasize that this fragment of the table is about the manifests for the pkcs11 API, to avoid confusion in case the reader was looking for the native messaging manifest.
Motivation
The documentation incorrectly claims that the path has to be absolute.
Additional details
Undocumented support for relative paths existed for a long while, and became an explicit first-class supported feature in https://bugzilla.mozilla.org/show_bug.cgi?id=1759162
Related issues and pull requests