Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): Clarify relationship between get/has/setAttribute() methods for attribute values, nodes & namespaced attrs #32268

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Feb 14, 2024

Description

This PR directs readers to non-namespaced and non-Attr variants of the Attribute methods (get, set, has, remove).

Additions:

  • "See also" sections listing complementary methods

Removals:

  • {{DOMAttributeMethods}} table

Motivation

Clarify the differences between these methods and remove {{DOMAttributeMethods}} macro.

Additional details

See Discussion: https://github.com/orgs/mdn/discussions/638

Failing builds

There is an issue following #31265. I am committing using git commit --no-verify ... to skip local checks.

…s for attribute values, nodes & namespaced attrs
@bsmth bsmth requested a review from a team as a code owner February 14, 2024 13:07
@bsmth bsmth requested review from Elchi3 and wbamberg and removed request for a team February 14, 2024 13:07
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Feb 14, 2024
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@wbamberg wbamberg merged commit 990ab66 into mdn:main Feb 15, 2024
7 of 8 checks passed
@bsmth bsmth deleted the disc-638-domattributemethods branch February 15, 2024 09:43
@bsmth
Copy link
Member Author

bsmth commented Feb 15, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants