Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(husky): force to update moved file links #31269

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Dec 24, 2023

The PR moves moved URL auto updates from nightly Github workflow to local husky. The move operation is only possible from local environment so it makes sense to have it enforced locally.

When you move a file and try to make a git commit, the husky precommit hook will execute node scripts/update-moved-file-links.js --check. If there are URLs to update then the commit operation will fail asking the user to run node scripts/update-moved-file-links.js to update all the URLs before trying the commit again.

ping @teoli2003

@OnkarRuikar OnkarRuikar requested review from a team as code owners December 24, 2023 14:40
@github-actions github-actions bot added the system [PR only] Infrastructure and configuration for the project label Dec 24, 2023
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 034bed2 into mdn:main Dec 24, 2023
8 of 9 checks passed
@OnkarRuikar OnkarRuikar deleted the husky_check_moved_files branch December 24, 2023 14:51
dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants