Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the support for -webkit-text-security in Release 114 #26817

Merged
merged 10 commits into from
May 23, 2023

Conversation

andreydanil
Copy link
Contributor

@andreydanil andreydanil commented May 17, 2023

Firefox is the only widely used engine not supporting -webkit-text-security, and it seems to be in use in the wild to conceal password fields, as per this webcompat.com report. Chrome Platform Status implies that its usage is low (~0.3%), but slowly growing.

Description

whatwg/compat#240

Motivation

Fixed in https://bugzilla.mozilla.org/show_bug.cgi?id=1826629 and released in Firefox 114.

Additional details

@andreydanil andreydanil requested a review from a team as a code owner May 17, 2023 16:09
@andreydanil andreydanil requested review from dipikabh and removed request for a team May 17, 2023 16:09
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label May 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2023

Preview URLs

Flaws (1)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/114
Title: Firefox 114 for developers
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/Web/CSS/-webkit-text-security
External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/114
Title: Firefox 114 for developers

(comment last updated: 2023-05-23 16:09:16)

@dipikabh dipikabh self-assigned this May 17, 2023
@andreydanil
Copy link
Contributor Author

PR for the browser compatibility update: mdn/browser-compat-data#19887.

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @andreydanil, thanks for opening the PRs to update content and BCD!

We add the Firefox release specific changes to our release docs. Would it be possible for you to update that file as part of this PR (basically move the update info from webkit-text-security to releases/114? Thanks!

files/en-us/web/css/-webkit-text-security/index.md Outdated Show resolved Hide resolved
@andreydanil andreydanil requested a review from a team as a code owner May 17, 2023 21:31
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label and removed Content:CSS Cascading Style Sheets docs labels May 17, 2023
@andreydanil andreydanil changed the title Remove non-standard text and add the support for -webkit-text-securit… Add the support for -webkit-text-security in Release 114 May 17, 2023
@andreydanil andreydanil requested a review from dipikabh May 17, 2023 21:53
…leases/114#css

Moving to https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/114#css

Simplify the verbiage

Fixing bugzilla bug url

Re-phrase the CSS update for 1826629

Update index.md

Restore the CSSRef to the original position

Headings should be surrounded by blank lines
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the updates!

I've suggested a rewording here. Please cross-check for technical accuracy.

  • On the content page, two things are still required:
    • In the first sentence, "webkit-text-security is a non-standard CSS property" should now be "webkit-text-security is a CSS property"
    • {{ Non-standard_header() }} needs to be removed
  • I left a comment in the BCD PR.

files/en-us/mozilla/firefox/releases/114/index.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label May 18, 2023
@andreydanil andreydanil requested a review from dipikabh May 18, 2023 15:10
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 👍

files/en-us/mozilla/firefox/releases/114/index.md Outdated Show resolved Hide resolved
@dipikabh dipikabh merged commit 2c4d2d5 into mdn:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants