Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix URL fragments #25967

Merged
merged 2 commits into from
Apr 7, 2023
Merged

fix URL fragments #25967

merged 2 commits into from
Apr 7, 2023

Conversation

dalvg
Copy link
Contributor

@dalvg dalvg commented Apr 6, 2023

Description

Addressed some broken URL fragments from 25421

Motivation

Additional details

Related issues and pull requests

@dalvg dalvg requested review from a team as code owners April 6, 2023 17:26
@dalvg dalvg requested review from Josh-Cena and hamishwillee and removed request for a team April 6, 2023 17:26
@github-actions github-actions bot added Content:JS JavaScript docs Content:Learn Learning area docs Content:Other Any docs not covered by another "Content:" label labels Apr 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Preview URLs (7 pages)
Flaws (2)

Note! 5 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Learn/JavaScript/Howto
Title: Solve common problems in your JavaScript code
Flaw count: 1

  • broken_links:
    • Anchor not lowercase

URL: /en-US/docs/Web/JavaScript/Reference/Template_literals
Title: Template literals (Template strings)
Flaw count: 1

  • broken_links:
    • Anchor not lowercase

wbamberg
wbamberg approved these changes Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 these all look great, thank you @dalvg !

@wbamberg wbamberg merged commit b8f5e2a into mdn:main Apr 7, 2023
@dalvg dalvg deleted the fixfragments branch April 7, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner automatically assigned from mdn/yari-content-javascript

@hamishwillee hamishwillee Awaiting requested review from hamishwillee hamishwillee is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:JS JavaScript docs Content:Learn Learning area docs Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dalvg @wbamberg