Update MediaQueryList support for Safari. (inheriting EventTarget) #7344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
sideshowbarker
approved these changes
Nov 12, 2020
|
Nice catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, it shipped in Safari 14.
I suppose #6745 barely missed making this change, since it updated the
onchangesupport.https://bugs.webkit.org/show_bug.cgi?id=203288#c21 commit landing in april 2020.
saf 14 shipped in june 2020.
I tested saf 14 and indeed it has it all there:
context: i started looking at this because of paulirish/matchMedia.js#86