Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec_url of @charset from css2 to css3 #25574

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

skyclouds2001
Copy link
Contributor

Summary

Test results and supporting details

Related issues

@skyclouds2001 skyclouds2001 marked this pull request as ready for review January 4, 2025 15:58
@github-actions github-actions bot added data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:xs [PR only] 0-6 LoC changed labels Jan 4, 2025
@skyclouds2001 skyclouds2001 changed the title Update spec_url from css2 to css3 for @charset Update spec_url of @charset from css2 to css3 Jan 4, 2025
@@ -5,7 +5,7 @@
"__compat": {
"description": "`@charset`",
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/@charset",
"spec_url": "https://drafts.csswg.org/css2/#charset",
"spec_url": "https://drafts.csswg.org/css-syntax/#at-ruledef-charset",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we link to the published CRD instead?

Suggested change
"spec_url": "https://drafts.csswg.org/css-syntax/#at-ruledef-charset",
"spec_url": "https://www.w3.org/TR/css-syntax-3/#at-ruledef-charset",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for css features, Editor’s Draft is the mostly used; and W3C Candidate Recommendation Draft only used three cases (for spec_url is is only one case)

image

so I oppose this change due to consistence

@caugner caugner added the meeting agenda Issues or pull requests in need of discussion in a project meeting. label Jan 6, 2025
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might migrate to CR draft, and we'll probably discuss this soon, but for now, this LGTM.

@caugner caugner merged commit cfdc681 into mdn:main Jan 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS meeting agenda Issues or pull requests in need of discussion in a project meeting. size:xs [PR only] 0-6 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants