Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate spec link for some media query features #25532

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

skyclouds2001
Copy link
Contributor

Summary

the https://drafts.csswg.org/mediaqueries/ and https://drafts.csswg.org/mediaqueries-4/ refers to the same documentation, so it is fine to only keep one of them

Test results and supporting details

Related issues

@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 29, 2024 16:52
@github-actions github-actions bot added data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:s [PR only] 7-24 LoC changed labels Dec 29, 2024
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, but I feel like we should lint this, and prefer https://drafts.csswg.org/mediaqueries-4/, which is mentioned in the header:

https://github.com/w3c/csswg-drafts/blob/2f1a48a2116ce90a7728367b60629555c61df085/mediaqueries-4/Overview.bs#L10

@caugner caugner merged commit 2a27d38 into mdn:main Jan 3, 2025
8 checks passed
@skyclouds2001 skyclouds2001 deleted the media-query branch January 3, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:s [PR only] 7-24 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants