Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chromium data for webextensions.api.windows.create.createData #23904

Conversation

queengooborg
Copy link
Contributor

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the create.createData member of the windows Web Extensions interface. This sets the feature(s) to a version range based upon the date that the feature was added to BCD with the intent of replacing true values with ranged values to eliminate true values from BCD.

Commit/PR Adding the Feature: #456

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `create.createData` member of the `windows` Web Extensions interface. This sets the feature(s) to a version range based upon the date that the feature was added to BCD with the intent of replacing `true` values with ranged values to eliminate `true` values from BCD.

Commit/PR Adding the Feature: mdn#456
@queengooborg queengooborg added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Jul 20, 2024
@@ -766,7 +766,7 @@
"__compat": {
"support": {
"chrome": {
"version_added": true
"version_added": "≤61"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't this (and top, type, and width) added in 302 - e.g. ≤60

@@ -791,7 +791,7 @@
"__compat": {
"support": {
"chrome": {
"version_added": true
"version_added": "≤61"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was updated in #456 so presumably was added earlier

@@ -816,7 +816,7 @@
"__compat": {
"support": {
"chrome": {
"version_added": true
"version_added": "≤61"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also an update in #456

},
"edge": {
"version_added": "79"
"version_added": "≤61"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also an update in #456

@@ -960,7 +958,7 @@
"__compat": {
"support": {
"chrome": {
"version_added": true
"version_added": "≤61"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also an update in #456

@queengooborg queengooborg merged commit 600be90 into mdn:main Aug 1, 2024
6 checks passed
@queengooborg queengooborg deleted the webextensions/api/windows/create/createData/chrome-corrections branch August 1, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants