Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browser versions for sandbox="allow-popups" #23864

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

foolip
Copy link
Contributor

@foolip foolip commented Jul 19, 2024

This was implemented in WebKit 535.8:
WebKit/WebKit@78f8706
https://github.com/WebKit/WebKit/blob/78f87065d871ddf0bb9d4c77310f62ae6375df47/Source/WebCore/Configurations/Version.xcconfig

That maps to Chrome 17 and Safari 6.

The commit message mentions support in IE10, which is confirmed by this
proposal from the time:
https://www.w3.org/html/wg/wiki/ChangeProposals/sandbox_allow_popups

Thus it must have been in Edge 12 as well.

@foolip foolip requested a review from ddbeck July 19, 2024 12:59
@github-actions github-actions bot added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Jul 19, 2024
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Jul 22, 2024
This was implemented in WebKit 535.8:
WebKit/WebKit@78f8706
https://github.com/WebKit/WebKit/blob/78f87065d871ddf0bb9d4c77310f62ae6375df47/Source/WebCore/Configurations/Version.xcconfig

That maps to Chrome 17 and Safari 6.

The commit message mentions support in IE10, which is confirmed by this
proposal from the time:
https://www.w3.org/html/wg/wiki/ChangeProposals/sandbox_allow_popups

Thus it must have been in Edge 12 as well.
@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Jul 22, 2024
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@Elchi3 Elchi3 merged commit b44e9b0 into mdn:main Jul 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants