Firefox 91 gamepad permission policy #11770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data:api
hamishwillee
commented
Jul 26, 2021
hamishwillee
commented
Jul 26, 2021
hamishwillee
commented
Jul 26, 2021
hamishwillee
commented
Jul 26, 2021
This was referenced Jul 26, 2021
hamishwillee
force-pushed
the
ff91_gamepad
branch
from
31bd866 to
eb05b36
Compare
hamishwillee
commented
Jul 30, 2021
|
@ddbeck Could you please review or help find a reviewer for this? |
ddbeck
requested changes
Aug 3, 2021
There was a problem hiding this comment.
A couple of suggestions for you (one from me, another from Marcos). Thanks, @hamishwillee.
Co-authored-by: Marcos Cáceres <[email protected]>
|
Thanks very much. Your changes/suggestions accepted. |
ddbeck
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FF91 adds
gamepadfeature policy (permission policy) directive. This is spec non-compliant in that the default policy is * (all) rather thanself(is a temporary bug fix):This was added to Chromium based things in v86 behind a preference: https://bugs.chromium.org/p/chromium/issues/detail?id=1011006. This is supposed to be removed soon. There is no evidence this is in Safari - see Moz bug above.