Skip to content

Commit

Permalink
Chrome 117/121 support unsetting bind group by passing null to setBin…
Browse files Browse the repository at this point in the history
…dGroup() (#24936)

* Unset bind group by passing null to setBindGroup()

* Deno/Safari don't support passing null to setBindGroup()

Sources:
- Deno: https://github.com/search?q=repo%3Adenoland%2Fdeno%20setBindGroup&type=code
- Safari: https://github.com/search?q=repo%3AWebKit%2FWebKit%20setBindGroup&type=code

---------

Co-authored-by: Claas Augner <[email protected]>
  • Loading branch information
chrisdavidmills and caugner authored Nov 15, 2024
1 parent aa61eb2 commit 18a60c0
Show file tree
Hide file tree
Showing 3 changed files with 120 additions and 0 deletions.
40 changes: 40 additions & 0 deletions api/GPUComputePassEncoder.json
Original file line number Diff line number Diff line change
Expand Up @@ -542,6 +542,46 @@
"standard_track": true,
"deprecated": false
}
},
"unset_bind_group": {
"__compat": {
"description": "Pass <code>null</code> to unset bind group",
"support": {
"chrome": {
"version_added": "117",
"notes": "Currently supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "121"
},
"deno": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": false
},
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": false
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": true,
"standard_track": true,
"deprecated": false
}
}
}
},
"setPipeline": {
Expand Down
40 changes: 40 additions & 0 deletions api/GPURenderBundleEncoder.json
Original file line number Diff line number Diff line change
Expand Up @@ -651,6 +651,46 @@
"standard_track": true,
"deprecated": false
}
},
"unset_bind_group": {
"__compat": {
"description": "Pass <code>null</code> to unset bind group",
"support": {
"chrome": {
"version_added": "117",
"notes": "Currently supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "121"
},
"deno": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": false
},
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": false
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": true,
"standard_track": true,
"deprecated": false
}
}
}
},
"setIndexBuffer": {
Expand Down
40 changes: 40 additions & 0 deletions api/GPURenderPassEncoder.json
Original file line number Diff line number Diff line change
Expand Up @@ -839,6 +839,46 @@
"standard_track": true,
"deprecated": false
}
},
"unset_bind_group": {
"__compat": {
"description": "Pass <code>null</code> to unset bind group",
"support": {
"chrome": {
"version_added": "117",
"notes": "Currently supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "121"
},
"deno": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": false
},
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": false
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": true,
"standard_track": true,
"deprecated": false
}
}
}
},
"setBlendConstant": {
Expand Down

0 comments on commit 18a60c0

Please sign in to comment.