Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small patch series2 (edited) #254

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Small patch series2 (edited) #254

wants to merge 5 commits into from

Conversation

mdkinney
Copy link
Owner

@mdkinney mdkinney commented Apr 29, 2020 •
edited
Loading

Description of small patch series 2 (edited)

mdkinney added 4 commits April 29, 2020 10:47
@mdkinney
Add new file 1.txt
ff9978c 
Another line

3rd line

Signed-off-by: Michael D Kinney <[email protected]>
@mdkinney
Add new file 2.txt
e9cb791 
Another line

3rd line

Signed-off-by: Michael D Kinney <[email protected]>
@mdkinney
Add new file 3.txt
56c39a9 
Another line

3rd line

Signed-off-by: Michael D Kinney <[email protected]>
@mdkinney
Add new file 4.txt
a8d4378 
Another line

3rd line

Signed-off-by: Michael D Kinney <[email protected]>
@mdkinney mdkinney force-pushed the SmallPatchSeries2 branch from 1358619 to d041a05 Compare April 29, 2020 17:52
@mdkinney mdkinney closed this Apr 29, 2020
@mdkinney
Copy link
Owner Author

Re-open the pull request

@mdkinney mdkinney reopened this Apr 29, 2020
@mdkinney mdkinney changed the title Small patch series2 Small patch series2 (edited) Apr 29, 2020
@mdkinney
Copy link
Owner Author

mdkinney commented Apr 29, 2020 •
edited
Loading

Add a PR scoped comment (with edits)

@mdkinney
Copy link
Owner Author

mdkinney commented Apr 29, 2020 •
edited
Loading

Reply to reply of a PR scoped comment (with more edits)

mdkinney
mdkinney commented Apr 30, 2020
View reviewed changes
Copy link
Owner Author

@mdkinney mdkinney left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR review with no file comments (edited again)

@mdkinney
Copy link
Owner Author

Add reply to PR review

@mdkinney
Copy link
Owner Author

Add commnt

mdkinney
mdkinney commented Apr 30, 2020
View reviewed changes
1.txt
@@ -0,0 +1,44 @@
Hello
Copy link
Owner Author

@mdkinney mdkinney Apr 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a single review comment at line 1 of 1.txt (edited)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add reply to reply

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add another reply to see reactions

Copy link
Owner Author

@mdkinney mdkinney May 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start a review in reply to a single comment (edited)

mdkinney
mdkinney commented May 1, 2020
View reviewed changes
Copy link
Owner Author

@mdkinney mdkinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finish review of 2.txt

2.txt
@@ -0,0 +1,44 @@
Hello
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start a review at first line of 2.txt

Copy link
Owner Author

@mdkinney mdkinney May 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add reply(edit)

2.txt
Hello
World
Hello
World
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to start a review at last line of 2.txt

2.txt
Hello
World
Hello
World
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a 3rd comment at line 22 of 2.txt

mdkinney
mdkinney commented May 1, 2020
View reviewed changes
Copy link
Owner Author

@mdkinney mdkinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finish 2nd review

2.txt
@@ -0,0 +1,44 @@
Hello
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start a 2nd review at first line of 2.txt

2.txt
Hello
World
Hello
World
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add commet line 6 of 2.txt

mdkinney
mdkinney commented May 1, 2020
View reviewed changes
Copy link
Owner Author

@mdkinney mdkinney left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finish 3rd review (edited)

1.txt
@@ -0,0 +1,44 @@
Hello
Copy link
Owner Author

@mdkinney mdkinney May 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start a review in reply to a single comment (edited)

1.txt
@@ -0,0 +1,44 @@
Hello
World
Hello
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to review

alpha633
alpha633 suggested changes May 1, 2020
View reviewed changes
Copy link

@alpha633 alpha633 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request some changes

1.txt
Hello
World
Hello
World
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start a review line 20 of 1.txt

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reply

1.txt
World
Hello
World
Hello
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment at line 25 of 1.txt

alpha633
alpha633 previously approved these changes May 1, 2020
View reviewed changes
Copy link

@alpha633 alpha633 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve the changes

@mdkinney
Add new file 9.txt
402ddf0 
Another line

3rd line

Signed-off-by: Michael D Kinney <[email protected]>
@mdkinney mdkinney force-pushed the SmallPatchSeries2 branch from d041a05 to 402ddf0 Compare May 1, 2020 22:05
@mdkinney mdkinney closed this May 1, 2020
@mdkinney mdkinney reopened this May 1, 2020
@mdkinney
Copy link
Owner Author

mdkinney commented May 1, 2020

@tianocore Acked-by

@mergify mergify bot closed this Dec 18, 2020
@mergify
Copy link

mergify bot commented Dec 18, 2020

All checks passed. Auto close personal build.

@mdkinney mdkinney reopened this Jan 5, 2022
@mergify
Copy link

mergify bot commented Jan 5, 2022

All checks passed. Auto close personal build.

@mergify mergify bot closed this Jan 5, 2022
@mdkinney mdkinney reopened this Jan 5, 2022
@mergify
Copy link

mergify bot commented Jan 5, 2022

All checks passed. Auto close personal build.

@mergify mergify bot closed this Jan 5, 2022
@mdkinney mdkinney reopened this Jan 8, 2022
@mdkinney
Copy link
Owner Author

mdkinney commented Jan 8, 2022

Add comment 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpha633 alpha633 alpha633 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdkinney @alpha633