chore: improve datapack update by testing NamespaceFileType #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misode
suggested changes
Dec 22, 2024
| def test_namespaces(): | ||
| # Test that all namespaces are known | ||
| # It loads the vanilla jar and checks | ||
| # that there are no unknown namespaces |
There was a problem hiding this comment.
Shouldn't this be named test_scopes? Vanilla only has one namespace (minecraft)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds somes worldgen specific namespaces and a new test.
The new test improve beet update when mojang adds a new folder (recently the
itemsfolder). It's checking that when loading the vanilla resouce pack and data pack there is no unknown files.I'm not sure that it's the good way of doing it thought.