Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add items directory + __all__ to be importable #456

Merged
merged 3 commits into from
Dec 12, 2024
Merged

fix: add items directory + __all__ to be importable #456

merged 3 commits into from
Dec 12, 2024

Conversation

edayot
Copy link
Contributor

@edayot edayot commented Dec 12, 2024

The last misode PR didn't add the items directory.

It's also impossible to name it items because it overwrite an existing attribute of the class Pack.

@edayot edayot marked this pull request as ready for review December 12, 2024 18:17
misode
misode reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@misode misode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay huh I don't know how I missed that.

Sad we can't name it items, but oh well

beet/library/resource_pack.py Outdated Show resolved Hide resolved
@RitikShah RitikShah merged commit a834328 into mcbeet:main Dec 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misode misode misode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edayot @misode @RitikShah