axis_utils unit tests #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial implementations of unit tests for most of the public procedures in the axis_utils module. Currently, two tests fail: * frac_index (fails with r4_kind) * tranlon (fails with r8_kind)
Print more descriptive messages while running the axis utils unit tests.
Various improvements have been made to the axis_utils unit tests: * Replace real(const, KIND) with const_KIND * Fix the frac_index test * Replace include file with Automake macro definitions * Print more informative error messages
A unit test for `get_axis_cart` from `axis_utils2` has been implemented. The test fails; it must be determined whether this should be considered a flaw in `get_axis_cart`, or a flaw in the test.
Use an explicit kind for all real constants in `test_axis_utils.F90`.
Merge the `string` branch, which contains the extended version of `string` and the new `stringify` functions from `fms_string_utils_mod`.
`string()` has been modified to strip leading and trailing whitespace, making the `PRETTY()` macro redundant. The array stringification functions have also been removed, since they've been added to `fms_string_utils_mod` under the `stringify` interface.
Define the `C(x)` macro in a way that works on all compilers.
Revise the comments in `test_axis_utils.F90`
There's no obvious way to make the `C(x)` macro work with the Cray compiler, so it's been replaced with the global parameter `k`. To free up the `k` symbol, the array comparison subroutines have been refactored with new variable names.
For the sake of brevity, replace several instances of `FMS_TEST_KIND_` with the `k` parameter. The macro-based definition of `kind_str` has been replaced by an 'if/else' statement which sets `kind_str` at runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of axis_utils unit tests.