Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PMJ controller midi input profiles #1460

Merged

Conversation

@coveralls
Copy link

coveralls commented Oct 2, 2023

Coverage Status

coverage: 32.01% (+0.002%) from 32.008%
when pulling 60c1309 on yestalgia:Add/PMJ-Controller-MIDI-InputProfiles
into 183e892 on mcallegari:master.

@mcallegari
Copy link
Owner

@yestalgia will we ever get the fixed versions of these?

@yestalgia
Copy link
Contributor Author

@yestalgia will we ever get the fixed versions of these?

I'll email them again - shouldn't take long to fix

@yestalgia
Copy link
Contributor Author

This is now ready to merge.

@mcallegari
Copy link
Owner

mcallegari commented Nov 21, 2023

Please remove (again) 9 faders controller. It's already upstream:
https://github.com/mcallegari/qlcplus/blob/master/resources/inputprofiles/PMJ-9-Faders-Controller.qxi
Please rename "MIDIKEY" to "MidiKey" as indicated in the their website

@yestalgia yestalgia changed the title Add/pmj controller midi input profiles Add pmj controller midi input profiles Nov 22, 2023
@yestalgia yestalgia changed the title Add pmj controller midi input profiles Add PMJ controller midi input profiles Nov 22, 2023
@mcallegari
Copy link
Owner

Please rename also the file to PMJ-MidiKey.qxi, thanks

@mcallegari mcallegari merged commit 025f702 into mcallegari:master Nov 22, 2023
7 checks passed
@yestalgia yestalgia deleted the Add/PMJ-Controller-MIDI-InputProfiles branch June 10, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants