Scene editor: Immediately update tabs in when fixture selection changes #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when the view is changed between the Tab View and the All Fixtures View, only the fixtures selected in the General tab are populated. This adds a signal to update the tabs and consoles immediately when the selection changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the view is changed between the Tab View and the All Fixtures View, only the fixtures selected in the General tab are populated. This is somewhat confusing. The purpose appears to be so I can highlight a subset of fixtures, and "Copy current values to all fixtures" will only copy to the selected fixtures.
This adds a signal to update the tabs and consoles immediately when the selection changes.
This is submitted as a draft because populating all of the tabs when the selection changes is a little sluggish, there's a few optimizations I'd like to work on.
Alternatively, if this feature was supposed to be removed, let's remove the code for that in the Tab/All channels toggle as well.