ui: fix crash on pressing special auto-repeating accent keys (^, `, ´…

…) in virtual console slider on Windows Qt5 by ignoring unknown keyPress events with key=0 (e.g. tested with german QWERTZ keyboard layout)
mcallegari · Oct 13, 2024 · 3b8c640 · 3b8c640
1 parent c7de361
commit 3b8c640
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ui/src/virtualconsole/virtualconsole.cpp b/ui/src/virtualconsole/virtualconsole.cpp
@@ -1597,7 +1597,7 @@ void VirtualConsole::initContents()
 
 void VirtualConsole::keyPressEvent(QKeyEvent* event)
 {
-    if (event->isAutoRepeat() == true)
+    if (event->isAutoRepeat() == true || event->key() == 0)
     {
         event->ignore();
         return;
@@ -1611,7 +1611,7 @@ void VirtualConsole::keyPressEvent(QKeyEvent* event)
 
 void VirtualConsole::keyReleaseEvent(QKeyEvent* event)
 {
-    if (event->isAutoRepeat() == true)
+    if (event->isAutoRepeat() == true || event->key() == 0)
     {
         event->ignore();
         return;

diff --git a/ui/src/virtualconsole/virtualconsole.h b/ui/src/virtualconsole/virtualconsole.h
@@ -345,7 +345,7 @@ public slots:
      *********************************************************************/
 
 protected:
-    /** Handler for keyboard key presse events */
+    /** Handler for keyboard key press events */
     void keyPressEvent(QKeyEvent* event);
 
     /** Handler for keyboard key release events */