New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial POC for metric aggregations #35

Draft

CrAzE124 wants to merge 1 commit into mbuhot:master from CrAzE124:add-metrics-aggregations

CrAzE124 commented Jun 19, 2019

Still a WIP - submitting for some guidance in terms of

module layout (aggregations.metrics)?
completeness (should each agg be feature complete - i.e. including "scripts" and related concepts?)

If this looks good I'll move on to the other metric aggs! Looking forward to assisting on this.


          Initial POC for metric aggregations

e020f53

CrAzE124 mentioned this pull request

DSL for aggregations #2

Open

Owner

mbuhot commented Jun 19, 2019

Looks pretty good to me 👍

For the package name, I’d prefer we either

use mbuhot.eskotlin.aggregation to match the existing aggregation builders

Or 2) move the filter / nested aggregation builders into a mbuhot.eskotlin.aggregations.bucket package .

@nzcoffeem what do you think?

As for completeness, feel free to implement as much functionality as you require for your own projects and document any limitations in the code.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet