use day-of-week based headway periods #837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulJKim
reviewed
Oct 29, 2024
| end) | ||
| for {group, periods} <- map, | ||
| {period, %{"range_low" => low, "range_high" => high}} <- periods, | ||
| time_period = parse_time_period(period) do |
There was a problem hiding this comment.
since time_period could be nil and then is passed to the Headway struct, shouldn't the typespec for Headway.time_period() also include | nil?
There was a problem hiding this comment.
We're relying on the fact that falsy values act like a filter, so they actually get skipped and we don't create Headway structs for those.
Merged
|
Closing in favor of #839 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: Change RTS to read these new values, handle appropriately
This switches to reading the new day-of-week based headway periods.
Also modifies the config parsing code so it doesn't log errors when encountering unexpected data (which we'll have during the transition). Note that the current code will log errors in this case, so we expect to see some errors logged between deploying the signs-ui change and deploying this.