Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add a step to template for signs.json changes #802

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

cmaddox5
Copy link
Contributor

Summary of changes

Asana Ticket: ad-hoc

Added an additional item to the PR checklist. My understanding of signs.json is that the same content needs to live in both signs_ui and realtime_signs. This new item will help new contributors remember to update both.

Reviewer Checklist

  • Meets ticket's acceptance criteria
  • Any new or changed functions have typespecs
  • Tests were added for any new functionality (don't just rely on Codecov)
  • This branch was deployed to the staging environment and is currently running with no unexpected increase in warnings, and no errors or crashes (compare on Splunk: staging vs. prod)

@cmaddox5 cmaddox5 requested a review from a team as a code owner July 31, 2024 15:36
@mbta mbta deleted a comment from github-actions bot Jul 31, 2024
@cmaddox5 cmaddox5 changed the title chore: Added a step to template for signs.json changes chore: Add a step to template for signs.json changes Jul 31, 2024
@cmaddox5 cmaddox5 merged commit dd6e403 into main Jul 31, 2024
2 checks passed
@cmaddox5 cmaddox5 deleted the cm/update-pr-template branch July 31, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants