fix: handle split alert statuses for signs in headway mode #800
+26
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PaulJKim I think this should fix the issue you brought up here: #797 (comment)
|
sloanelybutsurely
force-pushed
the
push-opyupwmzvxsr
branch
2 times, most recently
from
9a2c6cf
to
7184498
Compare
sloanelybutsurely
force-pushed
the
push-opyupwmzvxsr
branch
from
7184498
to
4537a64
Compare
sloanelybutsurely
force-pushed
the
sloane/support-split-alert-status
branch
from
90c4be5
to
80cdebc
Compare
sloanelybutsurely
force-pushed
the
push-opyupwmzvxsr
branch
2 times, most recently
from
0e8dfa7
to
54f89a6
Compare
|
@sloanelybutsurely I'm not sure if we'd be maintaining the existing behavior by taking the first non-nil message. We might need to distill things back down to one 'max stop status' if it's a mezzanine sign with differing alert statuses for either line. https://github.com/mbta/realtime_signs/blob/main/lib/engine/alerts/fetcher.ex#L20-L52 |
sloanelybutsurely
force-pushed
the
push-opyupwmzvxsr
branch
from
54f89a6
to
ca83d39
Compare
@PaulJKim pointed out that mezzanine signs when set to `:headway` mode check alert status but that code hadn't been updated to handle when alert statuses are different between `top` and `bottom` source configurations. This change intercepts split alert status values passed to `get_alert_messages/2` and gets the highest priority alert status of the two using `Engine.Alerts.higher_priority_status/2` before continuing on to the existing implementation.
sloanelybutsurely
force-pushed
the
push-opyupwmzvxsr
branch
from
ca83d39
to
4e90417
Compare
sloanelybutsurely
merged commit 3153b1d
into
sloane/support-split-alert-status
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PaulJKim pointed out that mezzanine signs when set to
:headwaymode check alert status but that code hadn't been updated to handle when alert statuses are different betweentopandbottomsource configurations.This change intercepts split alert status values passed to
get_alert_messages/2and gets the highest priority alert status of the two usingEngine.Alerts.higher_priority_status/2before continuing on to the existing implementation.