fix: mark riverside as a terminal station

[sloanelybutsurely]

Summary of changes

Asana Ticket: "BRD" showing on GL terminals too early

Sets terminal: true for Riverside so when a prediction is 0 stops away BRD is not shown until within the predicted departure time.

Note: I still haven't reproduced the original issue locally. Any help verifying before merging is much appreciated.

Reviewer Checklist

• Meets ticket's acceptance criteria
• Any new or changed functions have typespecs
• Tests were added for any new functionality (don't just rely on Codecov)
• This branch was deployed to the staging environment and is currently running with no unexpected increase in warnings, and no errors or crashes (compare on Splunk: staging vs. prod)

[sloanelybutsurely]

If helpful for reference

• V3 API - Trip canonical-Green-D-C1-1 w/ stops
• V3 API - Stop 70160

[github-actions]

Coverage of commit 02d7101

Summary coverage rate:
  lines......: 73.3% (2019 of 2754 lines)
  functions..: 75.2% (565 of 751 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

[dmaltzan]

@sloanelybutsurely my fault for not specifying this in the ticket but could we ensure that this also gets fixed (or maybe was never broken) at Medford/Tufts and Union Square, in addition to Riverside? Those would be the complete set of terminals that have PA/ESS.

[digitalcora]

Huh, it looks like this was just an oversight from when real-time data was originally enabled for these signs (a long time ago!), and maybe we never noticed because we were rarely able to make departure predictions at this terminal. Pending @dmaltzan's comment it looks fine to me.

[digitalcora]

For reproducing the issue, it might help to reach out to Firas since he was originally able to do so. I'm also curious about exactly how it was done, since I haven't used Glides for testing before.

[sloanelybutsurely]

@dmaltzan looks like the Medford/Tufts and Union Square are both already marked as terminal stations

Station	Stop ID	Config
Medford/Tufts	70512	1, 2, 3
Union Square	70504	1, 2

[panentheos]

Since this is a very low-risk change, and pretty evidently correct by inspection, I think it would be fine to merge as-is. Definitely feel free to verify end-to-end if you'd like, though.

[sloanelybutsurely]

It seems something was/is keeping predictions based on Glides data from being created. I've deployed to dev-green to let Firas verify this fixes the issue.