Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for supporting GL Terminal predictions #698

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

PaulJKim
Copy link
Collaborator

Summary of changes

Asana Ticket: Add stop IDs for new GL terminal predictions

According to the Glides team, the places that will start having Glides-based predictions are:

  • Boston College
  • Cleveland Circle
  • Riverside
  • Union Square
  • Medford/Tufts
  • Mattapan

We only have countdown clocks at Riverside, Union Sq, and Medford/Tufts out of this list.

The configuration won't need to change for Medford Tufts or Riverside with the exception of starting to announce boardings.

The Union Sq platforms each serve both directions so they have special platform stop ids that help us tell riders which track a train is predicted to leave from. This is the same setup that we use at most heavy rail terminals.

@github-actions
Copy link

Coverage of commit a4b8d02

Summary coverage rate:
  lines......: 75.5% (1926 of 2552 lines)
  functions..: 77.1% (524 of 680 functions)
  branches...: no data found

Files changed coverage rate:
                                                             |Lines       |Functions  |Branches    
  Filename                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================
  lib/content/utilities.ex                                   |40.5%     74|75.0%     8|    -      0

Download coverage report

Copy link
Collaborator

@panentheos panentheos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me!

@PaulJKim PaulJKim merged commit 1f1f836 into main Sep 22, 2023
1 check passed
@PaulJKim PaulJKim deleted the pk/add-GL-terminal-stop-ids branch September 22, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants