Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude mezzanine zones from crowding announcements #697

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Exclude mezzanine zones from crowding announcements #697

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c62a6b
Exclude mezzanine zones from crowding announcements
PaulJKim Sep 18, 2023
5738373
Merge branch 'main' into pk/no-crowding-in-mezzanines
PaulJKim Sep 19, 2023
e59c451
Check if multi-source
PaulJKim Sep 19, 2023
23272e0
Fix tests
PaulJKim Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/content/message/predictions.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ defmodule Content.Message.Predictions do
true -> compute_minutes(predicted_time, certainty)
end

{crowding_data_confidence, crowding_description} = do_crowding(prediction)
{crowding_data_confidence, crowding_description} =
if zone == "m", do: {nil, nil}, else: do_crowding(prediction)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to trigger on multi-source signs, as opposed to the zone id (which AFAIK is arbitrary)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good point, I like that


case Content.Utilities.destination_for_prediction(
prediction.route_id,
Expand Down
Loading