Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suppress terminal and reverse predictions for RL #683

Merged
merged 1 commit into from
Aug 31, 2023
Merged

suppress terminal and reverse predictions for RL #683

merged 1 commit into from
Aug 31, 2023

Conversation

panentheos
Copy link
Collaborator

Summary of changes

https://app.asana.com/0/1205101743911491/1205386558729560/f

This suppresses terminal and reverse predictions for the red line. Note that this code was borrowed and modified from #611

@github-actions
Copy link

Coverage of commit 32de05f

Summary coverage rate:
  lines......: 76.6% (1891 of 2468 lines)
  functions..: 77.5% (517 of 667 functions)
  branches...: no data found

Files changed coverage rate:
                                                             |Lines       |Functions  |Branches    
  Filename                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================
  lib/predictions/predictions.ex                             |97.9%     48| 100%     7|    -      0

Download coverage report

@panentheos panentheos merged commit 097ea6c into main Aug 31, 2023
1 check passed
@panentheos panentheos deleted the bhw/rl-predictions branch August 31, 2023 17:21
PaulJKim added a commit that referenced this pull request Sep 27, 2023
@PaulJKim
Revert "suppress terminal and reverse predictions for RL (#683)"
8560b83 
This reverts commit 097ea6c.
@PaulJKim PaulJKim mentioned this pull request Sep 27, 2023
Merged
PaulJKim added a commit that referenced this pull request Sep 27, 2023
@PaulJKim
Revert "suppress terminal and reverse predictions for RL (#683)" (#702)
ee86b03 
This reverts commit 097ea6c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulJKim PaulJKim PaulJKim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panentheos @PaulJKim