Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OL crowding read loop selection #678

Merged
merged 21 commits into from
Aug 31, 2023
Merged

Conversation

PaulJKim
Copy link
Collaborator

Summary of changes

Asana Ticket: πŸŸ πŸ§‘β€πŸ€β€πŸ§‘πŸ”Š Interrupt Read Loop Selection Logic

This PR adds logic for whether crowding data should be read out with an "Approaching" announcement, an "Arriving" announcement" or not at all.

@github-actions
Copy link

Coverage of commit 5f38c89

Summary coverage rate:
  lines......: 76.1% (1947 of 2559 lines)
  functions..: 76.9% (520 of 676 functions)
  branches...: no data found

Files changed coverage rate:
                                                             |Lines       |Functions  |Branches    
  Filename                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================
  lib/content/audio/approaching.ex                           |70.4%     27| 100%     7|    -      0
  lib/content/audio/predictions.ex                           |98.1%     52| 100%     1|    -      0
  lib/content/audio/train_is_arriving.ex                     |48.4%     31| 100%     5|    -      0
  lib/content/message/predictions.ex                         |63.6%    107|66.7%    15|    -      0
  lib/engine/locations.ex                                    |61.5%     52|69.2%    13|    -      0
  lib/locations/location.ex                                  |50.0%      2| 100%     2|    -      0
  lib/signs/realtime.ex                                      |94.8%     58|90.9%    11|    -      0
  lib/signs/utilities/audio.ex                               |90.4%     83| 100%     7|    -      0

Download coverage report

@github-actions
Copy link

Coverage of commit a036bbb

Summary coverage rate:
  lines......: 75.6% (1912 of 2529 lines)
  functions..: 77.0% (518 of 673 functions)
  branches...: no data found

Files changed coverage rate:
                                                             |Lines       |Functions  |Branches    
  Filename                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================
  lib/signs/realtime.ex                                      |94.0%     50|90.0%    10|    -      0
  lib/signs/utilities/audio.ex                               |91.1%     90| 100%     8|    -      0

Download coverage report

@github-actions
Copy link

Coverage of commit 9346ac7

Summary coverage rate:
  lines......: 75.6% (1911 of 2528 lines)
  functions..: 77.0% (518 of 673 functions)
  branches...: no data found

Files changed coverage rate:
                                                             |Lines       |Functions  |Branches    
  Filename                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================
  lib/signs/realtime.ex                                      |94.0%     50|90.0%    10|    -      0
  lib/signs/utilities/audio.ex                               |91.1%     90| 100%     8|    -      0

Download coverage report

Copy link
Collaborator

@panentheos panentheos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@PaulJKim PaulJKim merged commit 84cf9d7 into main Aug 31, 2023
1 check passed
@PaulJKim PaulJKim deleted the pk/crowding-read-loop-selection branch August 31, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants