Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase red line gap filtering #676

Merged
merged 1 commit into from
Aug 18, 2023
Merged

increase red line gap filtering #676

merged 1 commit into from
Aug 18, 2023

Conversation

panentheos
Copy link
Collaborator

Summary of changes

Asana Ticket: Refine RL prediction filtering

This increases the threshold for filtering red line prediction "gaps" from 18 to 21 minutes.

@github-actions
Copy link

Coverage of commit e56c84d

Summary coverage rate:
  lines......: 77.5% (1928 of 2489 lines)
  functions..: 77.5% (518 of 668 functions)
  branches...: no data found

Files changed coverage rate:
                                                             |Lines       |Functions  |Branches    
  Filename                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================
  lib/signs/utilities/predictions.ex                         |96.9%     64| 100%    10|    -      0

Download coverage report

PaulJKim
PaulJKim approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@PaulJKim PaulJKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panentheos panentheos merged commit ed5b056 into main Aug 18, 2023
1 check passed
@panentheos panentheos deleted the bhw/red-line-gaps branch August 18, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulJKim PaulJKim PaulJKim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panentheos @PaulJKim