Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address early AM bugs #674

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Address early AM bugs #674

merged 2 commits into from
Aug 18, 2023

Conversation

PaulJKim
Copy link
Collaborator

@PaulJKim PaulJKim commented Aug 17, 2023

Summary of changes

Asana Ticket: Implement early AM prediction changes

While observing early AM predictions play out with Kevin and Jim, we spotted two bugs.

The first was that the Prudential MZ sign was filtering out reverse E branch predictions. This is because the filtering logic was using sign_ids to exempt Prudential and Symphony EB. Now, the logic uses stop_ids so Prudential's MZ EB line will now also be included in the filtering logic. This required an additional change to pass the stop_id to StoppedTrain messages so that the filtering logic could access it.
Screenshot 2023-08-17 at 10 31 40 AM

The second bug was one where the second line of MZ headway messages was sometimes getting cut off. This was because one of the lines was exiting the early AM state and therefore just passing along half of the headway message from the original content generation logic. To resolve this, the logic now will put the original headway message back together if the line has early AM state :none so that the proceeding logic will have both lines to work with.
Screenshot 2023-08-14 at 11 17 34 AM

While not related to early AM logic, there was also a minor config issue that we noticed during the observation as well where the Kenmore B platforms were using the green_trunk headway group. It's preferable for these platforms to use the green_b headway values so that we don't say that trains are coming more frequently than they are on the B branch platforms. There's also no reason the Kenmore WB B branch platform can't use the Boston Col headsign.

Copy link
Collaborator

@panentheos panentheos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@PaulJKim PaulJKim merged commit 20d3add into main Aug 18, 2023
1 check passed
@PaulJKim PaulJKim deleted the pk/early-am-bugfixes branch August 18, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants