Remove extra logging

mbta · Aug 26, 2024 · b005b04 · b005b04
1 parent 135c50a
commit b005b04
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 91 deletions.
diff --git a/lib/content/message/predictions.ex b/lib/content/message/predictions.ex
@@ -70,41 +70,6 @@ defmodule Content.Message.Predictions do
     # e.g., North Station which is non-terminal but has trips that begin there
     predicted_time = prediction.seconds_until_arrival || prediction.seconds_until_departure
 
-    if sign.id in [
-         "malden_center_platform",
-         "green_street_northbound",
-         "revere_beach_westbound",
-         "davis_southbound",
-         "quincy_adams_northbound",
-         "shawmut_northbound"
-       ] do
-      Logger.info([
-        "prediction_info: ",
-        "station_code=",
-        station_code,
-        " zone=",
-        zone,
-        " trip_id=",
-        prediction.trip_id,
-        " stop_id=",
-        prediction.stop_id,
-        " vehicle_id=",
-        inspect(prediction.vehicle_id),
-        " direction_id=",
-        inspect(prediction.direction_id),
-        " seconds_until_departure=",
-        inspect(prediction.seconds_until_departure),
-        " boarding_status=",
-        inspect(prediction.boarding_status),
-        " vehicle_status=",
-        inspect(prediction.vehicle_status),
-        " vehicle_location_stop_id=",
-        inspect(prediction.vehicle_location_stop_id),
-        " vehicle_location_trip_id=",
-        inspect(prediction.vehicle_location_trip_id)
-      ])
-    end
-
     certainty =
       if prediction.seconds_until_arrival,
         do: prediction.arrival_certainty,
@@ -210,43 +175,6 @@ defmodule Content.Message.Predictions do
           nil
       end
 
-    if prediction.seconds_until_departure + @terminal_prediction_offset_seconds <=
-         @terminal_brd_seconds do
-      Logger.info([
-        "prediction_info: ",
-        "station_code=",
-        station_code,
-        " zone=",
-        zone,
-        " trip_id=",
-        prediction.trip_id,
-        " stop_id=",
-        prediction.stop_id,
-        " vehicle_id=",
-        inspect(prediction.vehicle_id),
-        " direction_id=",
-        inspect(prediction.direction_id),
-        " seconds_until_departure=",
-        inspect(prediction.seconds_until_departure),
-        " boarding_status=",
-        inspect(prediction.boarding_status),
-        " stopped_at_predicted_stop=",
-        inspect(prediction.stopped_at_predicted_stop?),
-        " vehicle_status=",
-        inspect(prediction.vehicle_status),
-        " vehicle_location_stop_id=",
-        inspect(prediction.vehicle_location_stop_id),
-        " vehicle_location_trip_id=",
-        inspect(prediction.vehicle_location_trip_id),
-        " computed_minute=",
-        inspect(minutes),
-        " prediction_certainty=",
-        inspect(prediction.departure_certainty),
-        " terminal_prediction=",
-        inspect(terminal_prediction)
-      ])
-    end
-
     terminal_prediction
   end
 

diff --git a/lib/predictions/prediction.ex b/lib/predictions/prediction.ex
@@ -13,10 +13,7 @@ defmodule Predictions.Prediction do
             stopped_at_predicted_stop?: false,
             boarding_status: nil,
             revenue_trip?: true,
-            vehicle_id: nil,
-            vehicle_status: nil,
-            vehicle_location_stop_id: nil,
-            vehicle_location_trip_id: nil
+            vehicle_id: nil
 
   @type trip_id :: String.t()
 
@@ -35,9 +32,6 @@ defmodule Predictions.Prediction do
           stopped_at_predicted_stop?: boolean(),
           boarding_status: String.t() | nil,
           revenue_trip?: boolean(),
-          vehicle_id: String.t() | nil,
-          vehicle_status: :incoming_at | :stopped_at | :in_transit_to,
-          vehicle_location_stop_id: String.t(),
-          vehicle_location_trip_id: String.t()
+          vehicle_id: String.t() | nil
         }
 end
diff --git a/lib/predictions/predictions.ex b/lib/predictions/predictions.ex
@@ -88,13 +88,6 @@ defmodule Predictions.Predictions do
         else: nil
 
     vehicle_location = Engine.Locations.for_vehicle(vehicle_id)
-    vehicle_status = if not is_nil(vehicle_location), do: vehicle_location.status, else: "none"
-
-    vehicle_locaton_stop_id =
-      if not is_nil(vehicle_location), do: vehicle_location.stop_id, else: "none"
-
-    vehicle_location_trip_id =
-      if not is_nil(vehicle_location), do: vehicle_location.trip_id, else: "none"
 
     %Prediction{
       stop_id: stop_time_update["stop_id"],
@@ -113,10 +106,7 @@ defmodule Predictions.Predictions do
           stop_time_update["stop_id"] == vehicle_location.stop_id,
       boarding_status: stop_time_update["boarding_status"],
       revenue_trip?: revenue_trip?,
-      vehicle_id: vehicle_id,
-      vehicle_status: vehicle_status,
-      vehicle_location_stop_id: vehicle_locaton_stop_id,
-      vehicle_location_trip_id: vehicle_location_trip_id
+      vehicle_id: vehicle_id
     }
   end