Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task: Other basic backend infrastructure required to build a basic HR Glides app
Could be reviewed but doesn't have to be yet.Ready for code review and merging!Infra PRs for setting the
ENVIRONMENT
env_var:Edit: I pulled most of the work of setting the release into #26
Still to do:
ENVIRONMENT
andSENTRY_DSN
.Write tests.I think nothing left here is unit testable.This PR includes quite a lot:
dev.secret.exs
anddev.secret.example.exs
files (which I used for setting sentry config locally).Adds a release variable to the app.In Glides, this isSENTRY_RELEASE
orApplication.get_env(:sentry, :release)
, but then we started using it for other stuff, so I've just gone straight for a genericRELEASE
orApplication.get_env(:orbit, :release)
.Adds the release to the HTML head.So that it's possible to verify that the release is getting set correctly.This is definitely testable, I just haven't yet.Checklist
( )
Has tests(x)
Doesn't need tests. Nothing left here is unit testable.( )
Tests deferred (with justification)( )
Okayed the plan for the feature (e.g. the design files, or the Asana task)( )
Reviewed the feature as implemented (e.g. on dev-green, or saw screenshots)(x)
No review needed