Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Sentry (backend) #25

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Install Sentry (backend) #25

merged 6 commits into from
Jun 21, 2024

Conversation

skyqrose
Copy link
Member

@skyqrose skyqrose commented Jun 13, 2024

Asana Task: Other basic backend infrastructure required to build a basic HR Glides app

Could be reviewed but doesn't have to be yet. Ready for code review and merging!

Infra PRs for setting the ENVIRONMENT env_var:

Edit: I pulled most of the work of setting the release into #26

Still to do:

  • Make terraform PRs to set new env vars for ENVIRONMENT and SENTRY_DSN.
  • Write tests. I think nothing left here is unit testable.
  • Deploy to sandbox and check that it works.
    • In particular, check that source maps work, I'm still not sure about them.
  • Remove the DO NOT MERGE commit that allows me to trigger crashes.
  • (Probably not in this PR) once we have keycloak users, register the user as sentry metadata on each request.

This PR includes quite a lot:

  • New dev.secret.exs and dev.secret.example.exs files (which I used for setting sentry config locally).
  • Installs sentry, including releases and source maps.
  • Adds a release variable to the app.
    • In Glides, this is SENTRY_RELEASE or Application.get_env(:sentry, :release), but then we started using it for other stuff, so I've just gone straight for a generic RELEASE or Application.get_env(:orbit, :release).
  • Adds the release to the HTML head.
    • So that it's possible to verify that the release is getting set correctly.
    • This is definitely testable, I just haven't yet.

Checklist

  • Tests:
    • ( ) Has tests
    • (x) Doesn't need tests. Nothing left here is unit testable.
    • ( ) Tests deferred (with justification)
  • Product/Design sign off:
    • ( ) Okayed the plan for the feature (e.g. the design files, or the Asana task)
    • ( ) Reviewed the feature as implemented (e.g. on dev-green, or saw screenshots)
    • (x) No review needed

@skyqrose
Copy link
Member Author

Sentry reporting worked, and there's source maps: https://mbtace.sentry.io/issues/5487566542, https://mbtace.sentry.io/issues/5513834067

@skyqrose skyqrose removed the deploy-to-sandbox deploy this PR to sandbox label Jun 20, 2024
@skyqrose skyqrose marked this pull request as ready for review June 20, 2024 19:17
@skyqrose skyqrose requested a review from a team as a code owner June 20, 2024 19:17
@skyqrose
Copy link
Member Author

Okay, this is ready for review now!

@skyqrose skyqrose merged commit 851a724 into main Jun 21, 2024
8 of 9 checks passed
@skyqrose skyqrose deleted the sqr-elixir branch June 21, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants