feat: Radio frontend #164
Merged
feat: Radio frontend #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathcolo
commented
Oct 24, 2024
skyqrose
reviewed
Oct 25, 2024
skyqrose
approved these changes
Oct 31, 2024
| (!valid || loading) && "opacity-50", | ||
| ])} | ||
| onClick={() => { | ||
| onComplete(enteredRadio); |
There was a problem hiding this comment.
optional refactoring idea: I remember there was a thing about using form onSubmit instead of the button onClick for something else recently. Would it be better to make this button a submit button and do this call in the form's onSubmit handler instead too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task: 📐 Orbit radio UI implementation
Still need to do some testing on mobile (as of this writing I don't have my phone accessible), but otherwise this is radio added to the frontend list display + form pages in a #163-not-ready-yet compatible way. That PR should be merged first.
Checklist
(x)Has tests( )Doesn't need tests( )Tests deferred (with justification)(x)Okayed the plan for the feature (e.g. the design files, or the Asana task)( )Reviewed the feature as implemented (e.g. on dev-green, or saw screenshots)( )No review needed