feat: osi list shows officials' name with email as fallback #137
Conversation
| preload: [:signed_in_employee, :signed_in_by_user], | ||
| order_by: [desc: :signed_in_at] | ||
| join: u in assoc(si, :signed_in_by_user), | ||
| preload: [:signed_in_employee, signed_in_by_user: u], |
There was a problem hiding this comment.
suggestion (non-blocking): If you're already in here turning the preload for signed_in_by_user from the default (which uses a separate query - see here) to using an explicit join in the same query, it might be worth doing the same for signed_in_employee, thus turning this whole operation into a single query.
There was a problem hiding this comment.
ah! thanks, I see you did that in #103. why is that not the default preload behavior, though? I guess because Ecto wants joins to remain explicit?
There was a problem hiding this comment.
why is that not the default preload behavior, though?
I'm not sure - it's also possible that Ecto isn't able to generate the join statements fully programmatically in all cases or something? In any event it's just an interesting quirk to be aware of.
…er than separate query
Asana Task: 📐 Orbit: In-app view of completed sign-ins does not include official full name
Display officials' names in the list, with email address as fallback.
Checklist
(x)Has tests( )Doesn't need tests( )Tests deferred (with justification)(x)Okayed the plan for the feature (e.g. the design files, or the Asana task)( )Reviewed the feature as implemented (e.g. on dev-green, or saw screenshots)( )No review needed