Install React #11
Merged
Install React #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemald
reviewed
May 31, 2024
lemald
reviewed
May 31, 2024
Comment on lines
+6
to
+9
| 🪐 | ||
| <span className="text-[#ED8B00]">O</span> | ||
| <span className="text-[#DA291C]">r</span> | ||
| <span className="text-[#003DA5]">b</span>it |
There was a problem hiding this comment.
This was all @skyqrose, I just brought it over to the react side. I agree, WD Sky!
|
@mathcolo one general request, I think it would be best to follow the pattern of other apps like Glides and have a |
|
@lemald My guess is that came from |
It probably did, and point taken that we should just move it as part of another PR - as far as React itself goes, I think this looks good. |
lemald
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task: Install React and kick it off on application load
This patch:
.tool-versionsChecklist
(x)Has tests( )Doesn't need tests( )Tests deferred (with justification)(x)Okayed the plan for the feature (e.g. the design files, or the Asana task)( )Reviewed the feature as implemented (e.g. on dev-green, or saw screenshots)( )No review needed