Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: copy in specific folders and use Alpine #8

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

boringcactus
Copy link
Member

Copying in only the Mix files first lets the dependencies be cached, which should save a decent chunk of time in CI.

Using Alpine is more for consistency's sake than anything else, and I'd be at peace sticking with Debian if we had a compelling reason to.

@boringcactus boringcactus requested a review from a team November 9, 2023 22:38
@@ -1,17 +1,18 @@
# --- Set up Elixir build ---
FROM hexpm/elixir:1.15.7-erlang-26.1.2-debian-bullseye-20231009-slim as elixir-builder
FROM hexpm/elixir:1.15.7-erlang-26.1.2-alpine-3.18.4 as elixir-builder
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Alpine described as the preferred option in this slack, and from the new application checklist if we don't expect to need bash or curl baked in.

@boringcactus boringcactus merged commit 10c30c0 into main Nov 13, 2023
3 checks passed
@boringcactus boringcactus deleted the mth-dockerfile branch November 13, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants