feat: Search endpoint #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaylaBrady
commented
Jan 16, 2024
config/config.exs
Outdated
Comment on lines
36
to
38
| base_url_fn: fn -> | ||
| "https://#{Application.get_env(:mobile_app_backend, MobileAppBackend.Search.Algolia)[:app_id]}-dsn.algolia.net" | ||
| end |
There was a problem hiding this comment.
I don't love this as a function - probably would be nicer as an environment variable passed at runtime
There was a problem hiding this comment.
Looks like mix release doesn't support configuring functions in config! Going the env var approach - will open a PR in the devops repo
There was a problem hiding this comment.
There was a problem hiding this comment.
Should we add an .envrc.template so devs know what needs to be set locally?
There was a problem hiding this comment.
Added in 0b352df
Coverage of commit
|
Coverage of commit
|
boringcactus
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
I think it feels a little weird to be mocking the network call both via the application config and via options passed as a separate argument, and in a vacuum I'd rather stick to one or the other (maybe application config with something like Mox), but I think we already don't have a coherent approach to mocking, so adding one will be a separate task anyway, and this PR doesn't necessarily need to be blocked on taking care of that.
…jection Co-authored-by: Melody Horn <[email protected]>
Coverage of commit
|
Coverage of commit
|
Coverage of commit
|
This way the defined API url can be used for organizing test files without being relient on what is configured in the envrc.template
Coverage of commit
|
boringcactus
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket: https://app.asana.com/0/1205425564113216/1206267623655566/f
This is heavily inspired by how dotcom does algolia search. My goal was to extract the pieces that are most relevant for what we know now about how search will work in the app.
Some differences from dotcom:
functionality
organization
HttpPoison.encode_querycovers what we need.TODO: