fix: remove AppCheck #241
Merged
fix: remove AppCheck #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonTR
added
the
deploy to dev-orange
KaylaBrady
approved these changes
Nov 15, 2024
Comment on lines
-16
to
-19
| issuer: System.get_env("APP_CHECK_ISSUER"), | ||
| project: System.get_env("APP_CHECK_PROJECT"), | ||
| subjects: | ||
| "APP_CHECK_APP_IDS" |
There was a problem hiding this comment.
suggestion (non-blocking): We should remove these env var definitions from the .envrc.template file as well to prevent confusion. We should also remove them from the application's env var config in terraform in the devops repo - happy to talk more about terraform separately!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: remove appcheck
Remove AppCheck