feat: Make trip channel pull from ETS predictions #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaSimon
changed the title
KaylaBrady
approved these changes
Nov 6, 2024
| predictions_by_stop: %{Stop.id() => %{Prediction.id() => Prediction.t()}}, | ||
| trips: %{Trip.id() => Trip.t()}, | ||
| vehicles: %{Vehicle.id() => Vehicle.t()} | ||
| } | ||
|
|
||
| @type subscribe_trip_response :: %{ |
There was a problem hiding this comment.
suggestion(non-blocking): add the new trip_id field here
There was a problem hiding this comment.
Sorry, I don't understand what you mean?
There was a problem hiding this comment.
There is a trip_id field added to the map here, I think it would be worth adding to the typespec
There was a problem hiding this comment.
Ohh, okay yes, updated
lib/mobile_app_backend_web/channels/predictions_for_trip_channel.ex
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Fix trip details crash when trip not in service
Update the
predictions:trip:<trip_id>channel to use the same ETS table that predictions by stop are pulling from. This also better handles the case where the frontend passes an added trip ID that doesn't exist in the trips endpoint, which can happen frequently for vehicles near the end of a line. Now instead of crashing on the backend, an error is returned to the frontend.Added tests for new behavior