Take trip planner query params into account in the new trip planner #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyshull
temporarily deployed
to
dev-blue
GitHub Actions
Inactive
thecristen
requested changes
Nov 13, 2024
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Failure
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Error
thecristen
approved these changes
Nov 13, 2024
anthonyshull
temporarily deployed
to
dev-blue
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time selection is a little trickier because of the change and hide/show behavior. But, we decided to just set it to 'now' since links generated in the past won't work anyway. All other selections are reflected. You can test this by planning a trip with selections and then just switching to
/preview/trip-planner.