feat: include passthrough_time from rtr in enhanced trip update feed #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfauble
requested review from
a team,
Whoops and
lemald
and removed request for
a team and
Whoops
lemald
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: 🐛 [Investigate] Subway passthrough trips in Concentrate have schedule_relationship CANCELED
The initial fix for this was scoping down the bus block waiver logic which was inadvertently catching these sorts of updates and switching the schedule_relationship to cancelled. Once that issue was resolved, these updates were being caught in the added+skipped filter which was completely removing the updates from the downstream feed.