Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧠 Surface last_trip TripDescriptor through Concentrate enhanced feeds #348

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

bfauble
Copy link
Contributor

@bfauble bfauble commented Mar 27, 2024

Summary of changes

Asana Ticket: 🧠 Surface last_trip TripDescriptor through Concentrate enhanced feeds

  • Parse last_trip field from TripDescriptor in enhanced feeds.
  • Default to false if not present
  • Add field to TripDescriptor in VehiclePositions_enhanced feed
  • Add field to TripDescriptor in TripUpdates_enhanced feed

@bfauble bfauble requested a review from meagharty March 27, 2024 15:19
Copy link

Coverage of commit 50ff43c

Summary coverage rate:
  lines......: 92.9% (1404 of 1511 lines)
  functions..: 80.5% (457 of 568 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/encoder/trip_updates_enhanced.ex                  | 100%      5| 100%     4|    -      0
  lib/concentrate/encoder/vehicle_positions_enhanced.ex             |88.9%     18|75.0%     8|    -      0
  lib/concentrate/parser/gtfs_realtime_enhanced.ex                  |97.6%     82| 100%    17|    -      0
  lib/concentrate/trip_descriptor.ex                                |85.0%     20|73.5%    34|    -      0

Download coverage report

}
end

defp merge_schedule_relationship(%{schedule_relationship: :SCHEDULED}, second),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@bfauble bfauble merged commit dc28e82 into master Apr 3, 2024
27 checks passed
@bfauble bfauble deleted the bf-surface-last-trip-field branch April 3, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants