Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shuttle route definition to shuttles #1022

Merged
merged 14 commits into from
Oct 28, 2024

Conversation

meagharty
Copy link
Collaborator

Summary of changes

Asana Ticket: 🏹 Implement "Create/Edit Shuttle Route Definition" Basic View + Route Definition Section

The main bit to review in this PR is the shuttle form page on /shuttles/new, /shuttles/1/edit

You can populate your local database with example data for relations like Gtfs.Route, Shuttle.Shape with:
mix run priv/repo/seeds.exs
If you run into any issues with that, you may already have conflicting data in your local database; for fastest resolution, I'd recommend commenting out the conflicting parts of that script or completely resetting the data in your database via mix db.reset and re-running mix run priv/repo/seeds.exs

Reviewer Checklist

  • Meets ticket's acceptance criteria
  • Any new or changed functions have typespecs
  • Tests were added for any new functionality (don't just rely on Codecov)
  • This branch was deployed to the staging environment and is currently running with no unexpected increase in warnings, and no errors or crashes.

@meagharty meagharty marked this pull request as ready for review October 24, 2024 19:09
@meagharty meagharty requested review from a team and Whoops and removed request for a team October 24, 2024 19:09
@meagharty
Copy link
Collaborator Author

@Whoops this was discussed in standup but since you've been out sick: this PR isn't expected to match the mockups exactly. I wanted to get out some Ecto updates and changes to shuttles.ex so we can be aligned for the other tickets encompassing this page.

I expect that we will need to make changes to the heex files; this isn't intended to set any of that in stone.

@meagharty meagharty force-pushed the meag/implement-route-definition branch from e6d5d5e to dde2dd7 Compare October 24, 2024 19:15
Copy link
Collaborator

@Whoops Whoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One very minor, non-blocking annoyance I noted in testing, when creating a new shuttle, perhaps the status should be defaulted to draft, so that if the user doesn't explicitly select a status they can still save it?

@meagharty meagharty merged commit 9242444 into master Oct 28, 2024
11 checks passed
@meagharty meagharty deleted the meag/implement-route-definition branch October 28, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants