-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add shuttle route definition to shuttles #1022
Conversation
@Whoops this was discussed in standup but since you've been out sick: this PR isn't expected to match the mockups exactly. I wanted to get out some Ecto updates and changes to I expect that we will need to make changes to the heex files; this isn't intended to set any of that in stone. |
e6d5d5e
to
dde2dd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One very minor, non-blocking annoyance I noted in testing, when creating a new shuttle, perhaps the status should be defaulted to draft, so that if the user doesn't explicitly select a status they can still save it?
Summary of changes
Asana Ticket: 🏹 Implement "Create/Edit Shuttle Route Definition" Basic View + Route Definition Section
The main bit to review in this PR is the shuttle form page on
/shuttles/new
,/shuttles/1/edit
You can populate your local database with example data for relations like Gtfs.Route, Shuttle.Shape with:
mix run priv/repo/seeds.exs
If you run into any issues with that, you may already have conflicting data in your local database; for fastest resolution, I'd recommend commenting out the conflicting parts of that script or completely resetting the data in your database via
mix db.reset
and re-runningmix run priv/repo/seeds.exs
Reviewer Checklist