🏹 Upgrade Elixir version (#1024)

* chore: bump elixir & erlang versions

* fix: resolve warning deprication messages coming from Arrow

* fix: resolve sentry deprecations

* fix: resolve wallaby deprecation warnings

* fix: deprecation warnings in tests

* chore: minor dependency version bumps

* chore: update mox

* chore: update http_poison

* chore: update telemetry

* chore: update debian container

* fix: use string instead of charlist

* fix: address gettext deprecations

* fix: dialyzer deprecation

* fix: ignore .elixir_ls

* fix: remove unecessary error clause

* fix: ssl_opts is deprecated

* fix: using warning instead of warn on LoggerBackend

.gitignore

@@ -42,3 +42,5 @@ npm-debug.log
 
 # Screenshots taken by Wallaby
 /test/integration/screenshots
+
+.elixir_ls

.tool-versions

@@ -1,3 +1,3 @@
-elixir 1.14.5-otp-26
-erlang 26.1.2
+elixir 1.17.3-otp-27
+erlang 27.1.2
 nodejs 20.8.1

Dockerfile

@@ -1,6 +1,6 @@
-ARG ELIXIR_VERSION=1.14.5
-ARG ERLANG_VERSION=26.1.2
-ARG DEBIAN_VERSION=bullseye-20230612
+ARG ELIXIR_VERSION=1.17.3
+ARG ERLANG_VERSION=27.1.2
+ARG DEBIAN_VERSION=bullseye-20241016
 
 FROM hexpm/elixir:$ELIXIR_VERSION-erlang-$ERLANG_VERSION-debian-$DEBIAN_VERSION as elixir-builder
 
@@ -39,6 +39,7 @@ COPY config/config.exs config/
 COPY config/prod.exs config/
 
 RUN mix deps.compile
+RUN mix sentry.package_source_code
 
 COPY assets assets
 RUN npm ci --prefix assets

config/runtime.exs

@@ -56,11 +56,10 @@ if config_env() == :prod do
       root_source_code_path: File.cwd!(),
       tags: %{
         env: sentry_env
-      },
-      included_environments: [sentry_env]
+      }
 
     config :logger, Sentry.LoggerBackend,
-      level: :warn,
+      level: :warning,
       capture_log_messages: true
   end
 

lib/arrow/disruption_revision.ex

@@ -210,7 +210,7 @@ defmodule Arrow.DisruptionRevision do
 
       Enum.all?(days_of_week, fn day ->
         Enum.member?(
-          Enum.map(Date.range(start_date, end_date), fn date -> Date.day_of_week(date) end),
+          Enum.map(date_range(start_date, end_date), fn date -> Date.day_of_week(date) end),
           DayOfWeek.day_number(day)
         )
       end) ->
@@ -285,4 +285,12 @@ defmodule Arrow.DisruptionRevision do
         changeset
     end
   end
+
+  defp date_range(start_date, end_date) do
+    if Date.compare(start_date, end_date) == :gt do
+      Date.range(start_date, end_date, -1)
+    else
+      Date.range(start_date, end_date)
+    end
+  end
 end

lib/arrow/gtfs.ex

@@ -38,7 +38,7 @@ defmodule Arrow.Gtfs do
           :ok
 
         {:error, reason} = error ->
-          Logger.warn(
+          Logger.warning(
             "GTFS import or validation failed #{job_logging_params(job)} reason=#{inspect(reason)}"
           )
 
@@ -51,7 +51,7 @@ defmodule Arrow.Gtfs do
         :ok
 
       {:error, reason} = error ->
-        Logger.warn(
+        Logger.warning(
           "GTFS import or validation failed #{job_logging_params(job)} reason=#{inspect(reason)}"
         )
 

lib/arrow/repo.ex

@@ -22,7 +22,7 @@ defmodule Arrow.Repo do
 
     Keyword.merge(config,
       password: token,
-      ssl_opts: [
+      ssl: [
         cacertfile: Path.join(:code.priv_dir(:arrow), "aws-cert-bundle.pem"),
         verify: :verify_peer,
         server_name_indication: String.to_charlist(hostname),

lib/arrow_web.ex

@@ -32,7 +32,7 @@ defmodule ArrowWeb do
   def channel do
     quote do
       use Phoenix.Channel
-      import ArrowWeb.Gettext
+      use Gettext, backend: ArrowWeb.Gettext
     end
   end
 
@@ -41,7 +41,7 @@ defmodule ArrowWeb do
       use Phoenix.Controller, namespace: ArrowWeb
 
       import Plug.Conn
-      import ArrowWeb.Gettext
+      use Gettext, backend: ArrowWeb.Gettext
       alias ArrowWeb.Router.Helpers, as: Routes
 
       unquote(verified_routes())
@@ -63,7 +63,7 @@ defmodule ArrowWeb do
       use Phoenix.HTML
 
       import ArrowWeb.ErrorHelpers
-      import ArrowWeb.Gettext
+      use Gettext, backend: ArrowWeb.Gettext
       alias ArrowWeb.Router.Helpers, as: Routes
 
       # Import the `react_component` helper
@@ -77,7 +77,7 @@ defmodule ArrowWeb do
       import Phoenix.HTML
       # Core UI components and translation
       import ArrowWeb.CoreComponents
-      import ArrowWeb.Gettext
+      use Gettext, backend: ArrowWeb.Gettext
 
       # Shortcut for generating JS commands
       alias Phoenix.LiveView.JS

lib/arrow_web/components/core_components.ex

@@ -17,7 +17,7 @@ defmodule ArrowWeb.CoreComponents do
   use Phoenix.Component
 
   alias Phoenix.LiveView.JS
-  import ArrowWeb.Gettext
+  use Gettext, backend: ArrowWeb.Gettext
 
   @doc """
   Renders a modal.

lib/arrow_web/controllers/api/gtfs_import_controller.ex

@@ -101,7 +101,7 @@ defmodule ArrowWeb.API.GtfsImportController do
         json(conn, value)
 
       {:error, status, message} ->
-        Logger.warn("GtfsImportController unsuccessful request message=#{inspect(message)}")
+        Logger.warning("GtfsImportController unsuccessful request message=#{inspect(message)}")
         send_resp(conn, status, message)
 
       {:error, message} ->

lib/arrow_web/controllers/disruption_html/_table.html.heex

@@ -13,7 +13,7 @@
 
   <tbody>
     <%= for %{revisions: [revision]} = disruption <- @disruptions do %>
-      <tr class={if not revision.row_approved, do: 'bg-light-pink'}>
+      <tr class={if not revision.row_approved, do: "bg-light-pink"}>
         <td>
           <%= revision.title %>
         </td>

lib/arrow_web/controllers/shape_controller.ex

@@ -51,11 +51,6 @@ defmodule ArrowWeb.ShapeController do
         conn
         |> put_flash(:errors, reason)
         |> render(:new_bulk, errors: reason, shapes_upload: reset_upload)
-
-      error ->
-        conn
-        |> put_flash(:errors, error)
-        |> render(:new_bulk, errors: error, shapes_upload: reset_upload)
     end
   end
 

lib/arrow_web/gettext.ex

@@ -5,7 +5,7 @@ defmodule ArrowWeb.Gettext do
   By using [Gettext](https://hexdocs.pm/gettext),
   your module gains a set of macros for translations, for example:
 
-      import ArrowWeb.Gettext
+      use Gettext, backend: ArrowWeb.Gettext
 
       # Simple translation
       gettext("Here is the string to translate")
@@ -20,5 +20,5 @@ defmodule ArrowWeb.Gettext do
 
   See the [Gettext Docs](https://hexdocs.pm/gettext) for detailed usage.
   """
-  use Gettext, otp_app: :arrow
+  use Gettext.Backend, otp_app: :arrow
 end

lib/arrow_web/try_api_token_auth/cognito.ex

@@ -42,7 +42,7 @@ defmodule ArrowWeb.TryApiTokenAuth.Cognito do
           []
 
         response ->
-          :ok = Logger.warn("unexpected_aws_api_response: #{inspect(response)}")
+          :ok = Logger.warning("unexpected_aws_api_response: #{inspect(response)}")
           []
       end
 

lib/arrow_web/try_api_token_auth/keycloak.ex

@@ -17,7 +17,7 @@ defmodule ArrowWeb.TryApiTokenAuth.Keycloak do
       )
     else
       other ->
-        Logger.warn(
+        Logger.warning(
           "unexpected response when logging #{auth_token.username} in via Keycloak API: #{inspect(other)}"
         )
 

mix.exs

@@ -14,11 +14,10 @@ defmodule Arrow.MixProject do
       releases: releases(),
       dialyzer: [
         plt_add_apps: [:mix],
-        plt_add_deps: :transitive,
+        plt_add_deps: :app_tree,
         flags: [
           :unmatched_returns
-        ],
-        ignore_warnings: ".dialyzer.ignore-warnings"
+        ]
       ],
       preferred_cli_env: ["test.integration": :test],
       test_coverage: [tool: LcovEx, ignore_paths: ["deps/"]]
@@ -60,11 +59,11 @@ defmodule Arrow.MixProject do
       {:gettext, "~> 0.11"},
       {:guardian, "~> 2.0"},
       {:hackney, "~> 1.9"},
-      {:httpoison, "~> 1.6"},
+      {:httpoison, "~> 2.2"},
       {:ja_serializer, github: "mbta/ja_serializer", branch: "master"},
       {:jason, "~> 1.0"},
       {:lcov_ex, "~> 0.2", only: [:dev, :test], runtime: false},
-      {:mox, "~> 1.0.0", only: :test},
+      {:mox, "~> 1.2", only: :test},
       {:oban, "~> 2.18"},
       {:phoenix_ecto, "~> 4.0"},
       {:phoenix_live_reload, "~> 1.5", only: :dev},
@@ -76,17 +75,17 @@ defmodule Arrow.MixProject do
       {:phoenix, "~> 1.7.12"},
       {:plug_cowboy, "~> 2.1"},
       {:telemetry, "~> 1.2", override: true},
-      {:telemetry_poller, "~> 0.4"},
-      {:telemetry_metrics, "~> 0.4"},
+      {:telemetry_poller, "~> 1.1"},
+      {:telemetry_metrics, "~> 1.0"},
       {:postgrex, ">= 0.0.0"},
       # If react_phoenix changes, check assets/src/ReactPhoenix.js, too
       {:react_phoenix, "1.3.1"},
       {:tzdata, "~> 1.1"},
       {:ueberauth_cognito, "0.4.0"},
       {:ueberauth_oidcc, "~> 0.4.0"},
       {:ueberauth, "~> 0.10"},
-      {:wallaby, "~> 0.30.6", runtime: false, only: :test},
-      {:sentry, "~> 8.0"},
+      {:wallaby, "~> 0.30", runtime: false, only: :test},
+      {:sentry, "~> 10.7"},
       {:tailwind, "~> 0.2", runtime: Mix.env() == :dev},
       {:heroicons,
        github: "tailwindlabs/heroicons",