Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split single actions config into per-language #99

Merged
merged 1 commit into from
Mar 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 28 additions & 58 deletions .github/workflows/main.yml → .github/workflows/bazel.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,38 +12,42 @@
# See the License for the specific language governing permissions and
# limitations under the License.

name: "Build & test"
name: "Bazel"

# GitHub Actions does not support anchors:
# https://github.com/actions/runner/issues/1182
# so we need to duplicate paths below and manually keep them in sync.
on:
push:
branches: [ main ]
paths:
# Bazel configs
- WORKSPACE
# Bazel files
- '**/BUILD'
- '**/*.bazel'
- '**/*.bzl'
# Go source files
- '**/*.go'
# Relevant CI configs
- '.github/workflows/bazel.yaml' # this file

pull_request:
branches: [ main ]
paths:
# Bazel configs
- WORKSPACE
# Bazel files
- '**/BUILD'
- '**/*.bazel'
- '**/*.bzl'
# Go source files
- '**/*.go'
# Relevant CI configs
- '.github/workflows/bazel.yaml' # this file

jobs:
server:
strategy:
matrix:
go: [ '1.17', '1.16', '1.15', '1.14', '1.13', '1.12' ]
os: [ 'ubuntu-22.04' ]
runs-on: ${{ matrix.os }}
name: Go ${{ matrix.go }} on ${{ matrix.os }}
steps:
- name: Checkout repo
uses: actions/checkout@v2

- name: Setup Go
uses: actions/setup-go@v2
with:
go-version: ${{ matrix.go }}

- name: Build
run: go build -v ./...

- name: Run tests
run: make test VERBOSE=1

server-bazel:
bazel:
strategy:
matrix:
bazel: [ '4.2.2', '5.0.0' ]
Expand Down Expand Up @@ -84,37 +88,3 @@ jobs:

- name: Run tests
run: bazel test //...

ui:
strategy:
matrix:
node: [ '20', '18' ]
os: [ 'ubuntu-22.04' ]
runs-on: ${{ matrix.os }}
name: Node ${{ matrix.node }} on ${{ matrix.os }}
steps:
- name: Checkout repo
uses: actions/checkout@v2

- name: Setup Node
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node }}

- name: Cache node modules
uses: actions/cache@v2
env:
cache-name: cache-node-modules
with:
path: "~/.npm"
key: os-${{ runner.os }}-node-${{ matrix.node }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
os-${{ runner.os }}-node-${{ matrix.node }}-yarn-
os-${{ runner.os }}-node-
os-${{ runner.os }}-

- name: Install dependencies
run: cd web/ui && yarn install

- name: Build web app
run: cd web/ui && yarn run build
64 changes: 64 additions & 0 deletions .github/workflows/go.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
# Copyright 2024 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

name: "Go"

# GitHub Actions does not support anchors:
# https://github.com/actions/runner/issues/1182
# so we need to duplicate paths below and manually keep them in sync.
on:
push:
branches: [ main ]
paths:
# Go configs
- go.mod
- go.sum
# Go source files
- '**/*.go'
# Relevant CI configs
- '.github/workflows/go.yaml' # this file

pull_request:
branches: [ main ]
paths:
# Go configs
- go.mod
- go.sum
# Go source files
- '**/*.go'
# Relevant CI configs
- '.github/workflows/go.yaml' # this file

jobs:
go:
strategy:
matrix:
go: [ '1.17', '1.16', '1.15', '1.14', '1.13', '1.12' ]
os: [ 'ubuntu-22.04' ]
runs-on: ${{ matrix.os }}
name: Go ${{ matrix.go }} on ${{ matrix.os }}
steps:
- name: Checkout repo
uses: actions/checkout@v2

- name: Setup Go
uses: actions/setup-go@v2
with:
go-version: ${{ matrix.go }}

- name: Build
run: go build -v ./...

- name: Run tests
run: make test VERBOSE=1
70 changes: 70 additions & 0 deletions .github/workflows/node.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
# Copyright 2021 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

name: "Node"

# GitHub Actions does not support anchors:
# https://github.com/actions/runner/issues/1182
# so we need to duplicate paths below and manually keep them in sync.
on:
push:
branches: [ main ]
paths:
# Source files
- 'web/ui/**'
# Relevant CI configs
- '.github/workflows/node.yaml' # this file

pull_request:
branches: [ main ]
paths:
# Source files
- 'web/ui/**'
# Relevant CI configs
- '.github/workflows/node.yaml' # this file

jobs:
ui:
strategy:
matrix:
node: [ '20', '18' ]
os: [ 'ubuntu-22.04' ]
runs-on: ${{ matrix.os }}
name: Node ${{ matrix.node }} on ${{ matrix.os }}
steps:
- name: Checkout repo
uses: actions/checkout@v2

- name: Setup Node
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node }}

- name: Cache node modules
uses: actions/cache@v2
env:
cache-name: cache-node-modules
with:
path: "~/.npm"
key: os-${{ runner.os }}-node-${{ matrix.node }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
os-${{ runner.os }}-node-${{ matrix.node }}-yarn-
os-${{ runner.os }}-node-
os-${{ runner.os }}-

- name: Install dependencies
run: cd web/ui && yarn install

- name: Build web app
run: cd web/ui && yarn run build
12 changes: 9 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
# Notebook

[![Build Status][github-ci-badge]][github-ci-url]
[![Bazel][bazel-ci-badge]][bazel-ci-url]
[![Node][node-ci-badge]][node-ci-url]
[![Go][go-ci-badge]][go-ci-url]
[![Go docs][go-doc-badge]][go-doc-url]
[![Go Report Card][go-report-card-badge]][go-report-card-url]

[github-ci-badge]: https://github.com/mbrukman/notebook/actions/workflows/main.yml/badge.svg
[github-ci-url]: https://github.com/mbrukman/notebook/actions/workflows/main.yml
[bazel-ci-badge]: https://github.com/mbrukman/notebook/actions/workflows/bazel.yaml/badge.svg
[bazel-ci-url]: https://github.com/mbrukman/notebook/actions/workflows/bazel.yaml
[node-ci-badge]: https://github.com/mbrukman/notebook/actions/workflows/node.yaml/badge.svg
[node-ci-url]: https://github.com/mbrukman/notebook/actions/workflows/node.yaml
[go-ci-badge]: https://github.com/mbrukman/notebook/actions/workflows/go.yaml/badge.svg
[go-ci-url]: https://github.com/mbrukman/notebook/actions/workflows/go.yaml
[go-doc-badge]: http://img.shields.io/badge/godoc-reference-informational.svg
[go-doc-url]: https://pkg.go.dev/github.com/mbrukman/notebook
[go-report-card-badge]: https://goreportcard.com/badge/github.com/mbrukman/notebook
Expand Down
Loading