Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify allow(dead_code) to be only on windows in the Args struct #274

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

w1kee
Copy link
Contributor

@w1kee w1kee commented Jul 6, 2023

No description provided.

src/main.rs Outdated Show resolved Hide resolved
@mbrubeck
Copy link
Owner

mbrubeck commented Jul 7, 2023

Instead of allowing dead code, should we make this field #[cfg(unix)] so it just doesn't exist on other platforms?

@Johann150
Copy link
Collaborator

That would also be a nice option, if @w1kee wants to do that. It would require adjusting a few more places in the code.

I wasn't sure if #[cfg(unix)] can be used on things like fields in constructors but apparently that works too.

target_os = "windows" -> windows

Co-authored-by: Johann150 <[email protected]>
@Johann150 Johann150 merged commit e3154ae into mbrubeck:master Jul 7, 2023
3 checks passed
@Johann150
Copy link
Collaborator

Thanks for your contribution!

Johann150 added a commit that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants