remove non-needed code

x-pack/test/functional/apps/lens/group1/smokescreen.ts

@@ -10,7 +10,7 @@ import { range } from 'lodash';
 import { FtrProviderContext } from '../../../ftr_provider_context';
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
-  const { visualize, lens, timePicker } = getPageObjects(['visualize', 'lens', 'timePicker']);
+  const { visualize, lens } = getPageObjects(['visualize', 'lens']);
   const find = getService('find');
   const listingTable = getService('listingTable');
   const testSubjects = getService('testSubjects');
@@ -20,9 +20,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const config = getService('config');
 
   describe('lens smokescreen tests', () => {
-    before(async () => {
-      await timePicker.setDefaultAbsoluteRangeViaUiSettings();
-    });
     it('should allow creation of lens xy chart', async () => {
       await visualize.navigateToNewVisualization();
       await visualize.clickVisType('lens');

x-pack/test/functional/apps/lens/group2/field_formatters.ts

@@ -10,12 +10,7 @@ import { FIELD_FORMAT_IDS } from '@kbn/field-formats-plugin/common';
 import { FtrProviderContext } from '../../../ftr_provider_context';
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
-  const { visualize, lens, header, timePicker } = getPageObjects([
-    'visualize',
-    'lens',
-    'header',
-    'timePicker',
-  ]);
+  const { visualize, lens, header } = getPageObjects(['visualize', 'lens', 'header']);
   const retry = getService('retry');
   const fieldEditor = getService('fieldEditor');
   const dataViews = getService('dataViews');
@@ -25,7 +20,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       before(async () => {
         await visualize.navigateToNewVisualization();
         await visualize.clickVisType('lens');
-        await timePicker.setDefaultAbsoluteRangeViaUiSettings();
         await lens.switchToVisualization('lnsDatatable');
       });
 

x-pack/test/functional/apps/lens/group2/index.ts

@@ -13,7 +13,6 @@ export default ({ getService, loadTestFile, getPageObjects }: FtrProviderContext
   const log = getService('log');
   const esArchiver = getService('esArchiver');
   const kibanaServer = getService('kibanaServer');
-  const { timePicker } = getPageObjects(['timePicker']);
 
   describe('lens app - group 2', () => {
     const esArchive = 'x-pack/test/functional/es_archives/logstash_functional';
@@ -36,8 +35,6 @@ export default ({ getService, loadTestFile, getPageObjects }: FtrProviderContext
       fixtureDirs = localFixtures;
       indexPatternString = localIndexPatternString;
       await esNode.load(esArchive);
-      // changing the timepicker default here saves us from having to set it in Discover (~8s)
-      await timePicker.setDefaultAbsoluteRangeViaUiSettings();
       await kibanaServer.uiSettings.update({
         defaultIndex: indexPatternString,
         'dateFormat:tz': 'UTC',
@@ -48,7 +45,6 @@ export default ({ getService, loadTestFile, getPageObjects }: FtrProviderContext
 
     after(async () => {
       await esNode.unload(esArchive);
-      await timePicker.resetDefaultAbsoluteRangeViaUiSettings();
       await kibanaServer.importExport.unload(fixtureDirs.lensBasic);
       await kibanaServer.importExport.unload(fixtureDirs.lensDefault);
       await kibanaServer.savedObjects.cleanStandardList();

x-pack/test/functional/apps/lens/group2/layer_actions.ts

@@ -9,15 +9,12 @@ import expect from '@kbn/expect';
 import { FtrProviderContext } from '../../../ftr_provider_context';
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
-  const { visualize, lens, timePicker } = getPageObjects(['visualize', 'lens', 'timePicker']);
+  const { visualize, lens } = getPageObjects(['visualize', 'lens']);
   const find = getService('find');
   const testSubjects = getService('testSubjects');
   const retry = getService('retry');
 
   describe('lens layer actions tests', () => {
-    before(async () => {
-      await timePicker.setDefaultAbsoluteRangeViaUiSettings();
-    });
     it('should allow creation of lens xy chart', async () => {
       await visualize.navigateToNewVisualization();
       await visualize.clickVisType('lens');

x-pack/test/functional/apps/lens/group2/partition.ts

@@ -9,14 +9,14 @@ import expect from '@kbn/expect';
 import { FtrProviderContext } from '../../../ftr_provider_context';
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
-  const { visualize, lens, timePicker } = getPageObjects(['visualize', 'lens', 'timePicker']);
+  const { visualize, lens } = getPageObjects(['visualize', 'lens']);
   const testSubjects = getService('testSubjects');
 
   describe('lens partition charts', () => {
     before(async () => {
       await visualize.navigateToNewVisualization();
       await visualize.clickVisType('lens');
-      await timePicker.setDefaultAbsoluteRangeViaUiSettings();
+      await lens.goToTimeRange();
     });
 
     it('should be able to nest up to 3 levels for Pie charts', async () => {

x-pack/test/functional/apps/lens/group2/persistent_context.ts

@@ -36,6 +36,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
 
     after(async () => {
       await security.testUser.restoreDefaults();
+      await timePicker.resetDefaultAbsoluteRangeViaUiSettings();
     });
 
     describe('Navigation search', () => {

x-pack/test/functional/apps/lens/group2/table.ts

@@ -9,16 +9,13 @@ import expect from '@kbn/expect';
 import { FtrProviderContext } from '../../../ftr_provider_context';
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
-  const { visualize, lens, timePicker } = getPageObjects(['visualize', 'lens', 'timePicker']);
+  const { visualize, lens } = getPageObjects(['visualize', 'lens']);
   const listingTable = getService('listingTable');
   const find = getService('find');
   const retry = getService('retry');
   const testSubjects = getService('testSubjects');
 
   describe('lens datatable', () => {
-    before(async () => {
-      await timePicker.setDefaultAbsoluteRangeViaUiSettings();
-    });
     it('should able to sort a table by a column', async () => {
       await visualize.gotoVisualizationLandingPage();
       await listingTable.searchForItemWithName('lnsXYvis');

x-pack/test/functional/apps/lens/group2/table_dashboard.ts

@@ -9,12 +9,7 @@ import expect from '@kbn/expect';
 import { FtrProviderContext } from '../../../ftr_provider_context';
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
-  const { lens, visualize, dashboard, timePicker } = getPageObjects([
-    'lens',
-    'visualize',
-    'dashboard',
-    'timePicker',
-  ]);
+  const { lens, visualize, dashboard } = getPageObjects(['lens', 'visualize', 'dashboard']);
   const listingTable = getService('listingTable');
   const retry = getService('retry');
 
@@ -40,9 +35,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   };
 
   describe('lens table on dashboard', () => {
-    before(async () => {
-      await timePicker.setDefaultAbsoluteRangeViaUiSettings();
-    });
     it('should sort a table by column in dashboard edit mode', async () => {
       await visualize.gotoVisualizationLandingPage();
       await listingTable.searchForItemWithName('lnsXYvis');

x-pack/test/functional/apps/lens/group3/add_to_dashboard.ts

@@ -9,16 +9,14 @@ import expect from '@kbn/expect';
 import { FtrProviderContext } from '../../../ftr_provider_context';
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
-  const { dashboard, visualize, lens, timeToVisualize, common, header, timePicker } =
-    getPageObjects([
-      'dashboard',
-      'visualize',
-      'lens',
-      'timeToVisualize',
-      'common',
-      'header',
-      'timePicker',
-    ]);
+  const { dashboard, visualize, lens, timeToVisualize, common, header } = getPageObjects([
+    'dashboard',
+    'visualize',
+    'lens',
+    'timeToVisualize',
+    'common',
+    'header',
+  ]);
   const find = getService('find');
   const listingTable = getService('listingTable');
   const dashboardAddPanel = getService('dashboardAddPanel');
@@ -62,9 +60,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   };
 
   describe('lens add-to-dashboards tests', () => {
-    before(async () => {
-      await timePicker.setDefaultAbsoluteRangeViaUiSettings();
-    });
     it('should allow new lens to be added by value to a new dashboard', async () => {
       await createNewLens();
       await lens.save('New Lens from Modal', false, false, false, 'new');

x-pack/test/functional/apps/lens/group3/dashboard_inline_editing.ts

@@ -7,12 +7,11 @@
 import expect from '@kbn/expect';
 import { FtrProviderContext } from '../../../ftr_provider_context';
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
-  const { dashboard, visualize, lens, timeToVisualize, timePicker } = getPageObjects([
+  const { dashboard, visualize, lens, timeToVisualize } = getPageObjects([
     'dashboard',
     'visualize',
     'lens',
     'timeToVisualize',
-    'timePicker',
   ]);
   const find = getService('find');
   const log = getService('log');
@@ -43,9 +42,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   };
 
   describe('lens inline editing tests', () => {
-    before(async () => {
-      await timePicker.setDefaultAbsoluteRangeViaUiSettings();
-    });
     it('should allow inline editing of a by value visualization', async () => {
       await createNewLens();
       await lens.save('New Lens from Modal', false, false, false, 'new');

x-pack/test/functional/apps/lens/group3/epoch_millis.ts

@@ -9,7 +9,7 @@ import expect from '@kbn/expect';
 import { FtrProviderContext } from '../../../ftr_provider_context';
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
-  const { visualize, lens, timePicker } = getPageObjects(['visualize', 'lens', 'timePicker']);
+  const { visualize, lens } = getPageObjects(['visualize', 'lens']);
   const esArchiver = getService('esArchiver');
   const kibanaServer = getService('kibanaServer');
 
@@ -19,7 +19,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await kibanaServer.importExport.load(
         'x-pack/test/functional/fixtures/kbn_archiver/lens/epoch_millis.json'
       );
-      await timePicker.setDefaultAbsoluteRangeViaUiSettings();
     });
 
     after(async () => {

x-pack/test/functional/apps/lens/group3/runtime_fields.ts

@@ -9,21 +9,13 @@ import expect from '@kbn/expect';
 import { FtrProviderContext } from '../../../ftr_provider_context';
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
-  const { visualize, lens, header, timePicker } = getPageObjects([
-    'visualize',
-    'lens',
-    'header',
-    'timePicker',
-  ]);
+  const { visualize, lens, header } = getPageObjects(['visualize', 'lens', 'header']);
   const filterBar = getService('filterBar');
   const fieldEditor = getService('fieldEditor');
   const retry = getService('retry');
   const dataViews = getService('dataViews');
 
   describe('lens runtime fields', () => {
-    before(async () => {
-      await timePicker.setDefaultAbsoluteRangeViaUiSettings();
-    });
     it('should be able to add runtime field and use it', async () => {
       await visualize.navigateToNewVisualization();
       await visualize.clickVisType('lens');

x-pack/test/functional/apps/lens/group3/terms.ts

@@ -10,12 +10,7 @@ import moment from 'moment';
 import { FtrProviderContext } from '../../../ftr_provider_context';
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
-  const { visualize, lens, common, timePicker } = getPageObjects([
-    'visualize',
-    'lens',
-    'common',
-    'timePicker',
-  ]);
+  const { visualize, lens, common } = getPageObjects(['visualize', 'lens', 'common']);
   const elasticChart = getService('elasticChart');
   const testSubjects = getService('testSubjects');
   const comboBox = getService('comboBox');
@@ -26,9 +21,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const log = getService('log');
 
   describe('lens terms', () => {
-    before(async () => {
-      await timePicker.setDefaultAbsoluteRangeViaUiSettings();
-    });
     describe('lens multi terms suite', () => {
       it('should allow creation of lens xy chart with multi terms categories', async () => {
         await visualize.navigateToNewVisualization();

x-pack/test/functional/apps/lens/group4/chart_data.ts

@@ -11,12 +11,11 @@ import { range } from 'lodash';
 import { FtrProviderContext } from '../../../ftr_provider_context';
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
-  const { visualize, lens, timePicker } = getPageObjects(['visualize', 'lens', 'timePicker']);
+  const { visualize, lens } = getPageObjects(['visualize', 'lens']);
   const elasticChart = getService('elasticChart');
 
   describe('lens chart data', () => {
     before(async () => {
-      await timePicker.setDefaultAbsoluteRangeViaUiSettings();
       await visualize.navigateToNewVisualization();
       await visualize.clickVisType('lens');
       await elasticChart.setNewChartUiDebugFlag(true);

x-pack/test/functional/apps/lens/group4/color_mapping.ts

@@ -15,12 +15,11 @@ import {
 import { FtrProviderContext } from '../../../ftr_provider_context';
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
-  const { visualize, lens, timePicker } = getPageObjects(['visualize', 'lens', 'timePicker']);
+  const { visualize, lens } = getPageObjects(['visualize', 'lens']);
   const elasticChart = getService('elasticChart');
 
   describe('lens color mapping', () => {
     before(async () => {
-      await timePicker.setDefaultAbsoluteRangeViaUiSettings();
       await visualize.navigateToNewVisualization();
       await visualize.clickVisType('lens');
       await elasticChart.setNewChartUiDebugFlag(true);

x-pack/test/functional/apps/lens/group4/colors.ts

@@ -8,12 +8,9 @@ import { ElasticBrandPalette } from '@kbn/coloring';
 import { FtrProviderContext } from '../../../ftr_provider_context';
 
 export default function ({ getPageObjects }: FtrProviderContext) {
-  const { visualize, lens, timePicker } = getPageObjects(['visualize', 'lens', 'timePicker']);
+  const { visualize, lens } = getPageObjects(['visualize', 'lens']);
 
   describe('lens color palette tests', () => {
-    before(async () => {
-      await timePicker.setDefaultAbsoluteRangeViaUiSettings();
-    });
     it('should allow to pick legacy color palette in xy chart', async () => {
       await visualize.navigateToNewVisualization();
       await visualize.clickVisType('lens');

x-pack/test/functional/apps/lens/group4/dashboard.ts

@@ -50,7 +50,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         ],
         { skipBrowserRefresh: true }
       );
-      await timePicker.setDefaultAbsoluteRangeViaUiSettings();
     });
     after(async () => {
       await security.testUser.restoreDefaults();

x-pack/test/functional/apps/lens/group4/share.ts

@@ -9,15 +9,14 @@ import expect from '@kbn/expect';
 import { FtrProviderContext } from '../../../ftr_provider_context';
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
-  const { visualize, lens, timePicker } = getPageObjects(['visualize', 'lens', 'timePicker']);
+  const { visualize, lens } = getPageObjects(['visualize', 'lens']);
   const browser = getService('browser');
   const filterBarService = getService('filterBar');
   const queryBar = getService('queryBar');
 
   describe('lens share tests', () => {
     before(async () => {
       await visualize.gotoVisualizationLandingPage();
-      await timePicker.setDefaultAbsoluteRangeViaUiSettings();
     });
 
     afterEach(async () => {

x-pack/test/functional/apps/lens/group4/show_underlying_data.ts

@@ -8,16 +8,14 @@ import expect from '@kbn/expect';
 import { FtrProviderContext } from '../../../ftr_provider_context';
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
-  const { visualize, lens, common, header, discover, unifiedFieldList, timePicker } =
-    getPageObjects([
-      'visualize',
-      'lens',
-      'common',
-      'header',
-      'discover',
-      'unifiedFieldList',
-      'timePicker',
-    ]);
+  const { visualize, lens, common, header, discover, unifiedFieldList } = getPageObjects([
+    'visualize',
+    'lens',
+    'common',
+    'header',
+    'discover',
+    'unifiedFieldList',
+  ]);
   const queryBar = getService('queryBar');
   const filterBar = getService('filterBar');
   const listingTable = getService('listingTable');
@@ -26,9 +24,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const browser = getService('browser');
 
   describe('show underlying data', () => {
-    before(async () => {
-      await timePicker.setDefaultAbsoluteRangeViaUiSettings();
-    });
     it('should show the open button for a compatible saved visualization', async () => {
       await visualize.gotoVisualizationLandingPage();
       await listingTable.searchForItemWithName('lnsXYvis');