Skip to content
This repository has been archived by the owner on Nov 4, 2019. It is now read-only.

Fix storing changes in WikiPage for Python3 #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eseifert
Copy link

@eseifert eseifert commented Jun 7, 2016

WikiPage.store() method should call str.encode() after replacing newline characters. Otherwise, under Python 3 it will fail with

TypeError: 'str' does not support the buffer interface

WikiPage.store() method should call str.encode() after replacing newline characters. Otherwise, under Python 3 it will fail with

TypeError: 'str' does not support the buffer interface
@mblayman
Copy link
Owner

mblayman commented Jun 7, 2016

@eseifert thank you for your contribution!

I noticed that these lines don't have any test coverage. Would you be able to write a test for this? It would help prove that this works on Python 2 and Python 3.

Also, feel free to add yourself to the AUTHORS file.

Let me know if you have any questions. Thanks!

@mblayman
Copy link
Owner

I can't prove that this doesn't break Python 2 without some tests. The project is getting very light maintenance from me so I'm afraid I'll have to close this unless it can be verified for Python 2 and 3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants