Issue #263 - Request the removal of Geoman (Leaflet Plugin For Creati… #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or Creating And Editing Geometry Layers) from Home Map.
|
Please review and merge this edit. -K |
…html and forms.py to fix Issue mbari-org#261 - Content of detail views hidden behind page header mbari-org#261.
MBARIMike
reviewed
Oct 28, 2024
MBARIMike
reviewed
Oct 28, 2024
MBARIMike
reviewed
Oct 28, 2024
|
Mike,
The pull request for Geoman removal was sent 4 months ago. No, major changes to the css were not required that update.
However, I recently made changes to the view of various pages to resolve several reported issues, some including the view
of your Crispy Forms, so that css works with all. This involved updating the filter.css.
These updates were detailed as another change (by issue #261) within the original pull request. The css changes I have made
are needed so that specific page-based requests do not affect the entire UI. Please review and merge these pull requests.
Karen
…_______________
Karen A. Salamy
Associate SW Engineer, MBARI
P 831.775.1820 , F 831.775.1620
Monterey Bay Aquarium Research Institute (MBARI)
7700 Sandholdt Road, Moss Landing CA 95039
[ http://www.mbari.org/ | www.mbari.org ]
Advancing marine science and engineering to understand our changing ocean.
"If we knew what it was we were doing, it would not be called research, would it?" - Albert Einstein (1879-1955)
P Please consider the environment before printing this e-mail.
From: "Mike McCann" ***@***.***>
To: "mbari-org/SeafloorMappingDB" ***@***.***>
Cc: "Karen Salamy" ***@***.***>, "Assign" ***@***.***>
Sent: Monday, October 28, 2024 10:58:51 AM
Subject: Re: [mbari-org/SeafloorMappingDB] Issue #263 - Request the removal of Geoman (Leaflet Plugin For Creati… (PR #264)
[POSSIBLE IMPERSONATION: This message is using the name of an MBARI account holder and has originated from outside of the organization. Please review the content and sender information carefully.]
@MBARIMike commented on this pull request.
I'm curious about the new CSS IDs added to filters.css. Are they necessary for the removal of Geoman?
—
Reply to this email directly, [ #264 (review) | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/ADB52CJ22CYMME6EIAQYGELZ5Z3NXAVCNFSM6AAAAABJSREBMKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOJZHAYTKMZVGQ | unsubscribe ] .
You are receiving this because you were assigned. Message ID: ***@***.***>
|
|
Okay. I will merge this PR and pull to production, but there are still issues with detail page rendering. |
|
Hi Mike,
I know there are still some issues with pages rendering. You stated you wanted me to do
small incremental changes instead of larger updates all at once.
I will have more pull requests this week.
Karen
…_______________
Karen A. Salamy
Associate SW Engineer, MBARI
P 831.775.1820 , F 831.775.1620
Monterey Bay Aquarium Research Institute (MBARI)
7700 Sandholdt Road, Moss Landing CA 95039
[ http://www.mbari.org/ | www.mbari.org ]
Advancing marine science and engineering to understand our changing ocean.
"If we knew what it was we were doing, it would not be called research, would it?" - Albert Einstein (1879-1955)
P Please consider the environment before printing this e-mail.
From: "Mike McCann" ***@***.***>
To: "mbari-org" ***@***.***>
Cc: "Karen Salamy" ***@***.***>, "Assign" ***@***.***>
Sent: Monday, October 28, 2024 3:33:05 PM
Subject: Re: [mbari-org/SeafloorMappingDB] Issue #263 - Request the removal of Geoman (Leaflet Plugin For Creati… (PR #264)
[POSSIBLE IMPERSONATION: This message is using the name of an MBARI account holder and has originated from outside of the organization. Please review the content and sender information carefully.]
Okay. I will merge this PR and pull to production, but there are still issues with detail page rendering.
—
Reply to this email directly, [ #264 (comment) | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/ADB52COOZZXPGRNCOU6ZHTTZ523SDAVCNFSM6AAAAABJSREBMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBSG44TQMJYGE | unsubscribe ] .
You are receiving this because you were assigned. Message ID: ***@***.***>
|
|
This PR has been pulled to production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request the removal of Geoman (Leaflet Plugin For Creating And Editing Geometry Layers) from Home Map.
Geoman is not needed. Removing it from the SMDB UI code base.